CFBundleVersion is missing for binary release 1.1.0

[combinecommunity]

CFBundleVersion is missing for binary release 1.1.0

[freak4pc]

Hey @nikita-leonov, good catch!
Just want to confirm, are you a Carthage user? I believe SPM and CocoaPods add their own Info.plist.

[freak4pc]

Ney @nikita-leonov - I tried adding it into 1.2.0, can you try and let me know? Thanks !

[freak4pc]

Sorry to bug again, I'd just really want to make sure this is working finally :)
Mind confirming if you have a few moments @nikita-leonov, @danielob ?

[nikita-leonov]

@freak4pc sorry for a delay, me
and Daniel got a little bit swamped with a release. We will confirm tomorrow. Thanks!

[nikita-leonov]

Yes, we are integrating CombineExt with Carthage.

[danielob]

@freak4pc The compiled binary 1.2.0 still missing CFBundleVersion in the info.plist. I posted a PR to add target flag that is required for Xcode to update that.
#36

[freak4pc]

Did you check 1.3.0 @danielob ?

[nikita-leonov]

Did you check 1.3.0 @danielob ?

We did, and it is also missing Bundle Version, as Current Project Version is not set, as result Bundle Version was not generated.

[freak4pc]

Hey @nikita-leonov

I added the infra to fix this in 2ac6963.

Also, uploaded a new binary on top of the 1.2.0 release which should have the release in CFBundleVersion and short version as well. Can you please try? You might need to clear your Carthage cache: rm -rf ~/Library/Caches/carthage

[nikita-leonov]

@freak4pc the binary scenario works thanks! The build from source now completely broken. It is quite unfortunate that in our case we may use both scenarios so may need still to keep a private fork a some time.
Btw just our of curiosity, is cocoa pods scenario works fine without having a project file in place? It was a while since I used it.

[freak4pc]

@nikita-leonov Carthage is the only dependency manager which depends on a project.

TBH I don't mind checking that in. I'll add back the project.

[freak4pc]

@nikita-leonov I force-pushed adding the project back onto the last commit. You should be good to go now, let me know if you have any other issues.