Comments (12)
Hey @nikita-leonov, good catch!
Just want to confirm, are you a Carthage user? I believe SPM and CocoaPods add their own Info.plist.
from combineext.
Ney @nikita-leonov - I tried adding it into 1.2.0, can you try and let me know? Thanks !
from combineext.
Sorry to bug again, I'd just really want to make sure this is working finally :)
Mind confirming if you have a few moments @nikita-leonov, @danielob ?
from combineext.
@freak4pc sorry for a delay, me
and Daniel got a little bit swamped with a release. We will confirm tomorrow. Thanks!
from combineext.
Yes, we are integrating CombineExt with Carthage.
from combineext.
@freak4pc The compiled binary 1.2.0
still missing CFBundleVersion
in the info.plist
. I posted a PR to add target flag that is required for Xcode to update that.
#36
from combineext.
Did you check 1.3.0 @danielob ?
from combineext.
Did you check 1.3.0 @danielob ?
We did, and it is also missing Bundle Version, as Current Project Version is not set, as result Bundle Version was not generated.
from combineext.
Hey @nikita-leonov
I added the infra to fix this in 2ac6963.
Also, uploaded a new binary on top of the 1.2.0 release which should have the release in CFBundleVersion and short version as well. Can you please try? You might need to clear your Carthage cache: rm -rf ~/Library/Caches/carthage
from combineext.
@freak4pc the binary scenario works thanks! The build from source now completely broken. It is quite unfortunate that in our case we may use both scenarios so may need still to keep a private fork a some time.
Btw just our of curiosity, is cocoa pods scenario works fine without having a project file in place? It was a while since I used it.
from combineext.
@nikita-leonov Carthage is the only dependency manager which depends on a project.
TBH I don't mind checking that in. I'll add back the project.
from combineext.
@nikita-leonov I force-pushed adding the project back onto the last commit. You should be good to go now, let me know if you have any other issues.
from combineext.
Related Issues (20)
- Swift 5.6 Release? HOT 5
- ‘Replace’ Operator HOT 3
- More efficient collect by time/scheduler?
- Ability to create a Passthrough and CurrentValue relay from an existing subject HOT 1
- Issues with the xcodeproj file HOT 1
- Unable to build 1.7.0 with Carthage HOT 1
- Memory Leak in ReplaySubject, WithLatestFrom, and anything else that uses the DemandBuffer HOT 1
- Is Relay necessary? HOT 1
- Documentation Building Failing on Xcode 14.0 HOT 7
- Issues with RetryWhen HOT 6
- .just, .empty and .fail on AnyPublisher HOT 1
- issues with CurrentValueRelay and PassthroughRelay subscription HOT 1
- Can 'Action' be supported?
- Is there Combine equivalent to RxSwiftExt apply operator ? HOT 3
- withLatestFrom doesn't seem to be thread safe
- CombineLatestMany behavior for 0 publishers HOT 2
- Generic parameter 'S' shadows generic parameter from outer scope with the same name; this is an error in Swift 6
- Memory leak issue with PassthroughRelay
- Apple privacy manifest support HOT 2
- How to use WithLatestFrom with @Published
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from combineext.