can't create promise

[bsoule]

can't create promise

[bsoule]

/create-test-promise-2154 successfully creates a promise, but
/review-gmail-auth-PR-test still fails in the same manner as /review-gmail-auth-PR

could the bot-detection code have labelled me a bot because Slack tried to autofetch/prefetch those URLs after I initially typed them, but then no one clicked on them until hours later?

[dreeves]

ha, i figured it out. capital letters! we redirect to canonicalize the URL or something.

i'm actually in favor of solving this by doing no canonicalizing whatsoever. the urtext is exactly what the user typed -- completely case-sensitive and not trying to clean up any extra underscores or anything like that.

[dreeves]

Case-insensitivity is the default with the Express router but there's a setting to turn it off. One of these:

app.set('case sensitive routing', true)
router = express.Router({ caseSensitive: true })

I've also heard someone say you need to use regex-based routing instead of string-based routing to make case-sensitivity work. I doubt that's true but there may be other reasons to prefer regex-based routing anyway.

[chrisbutler]

@dreeves setting that case-insensitivity wouldn't work for our case... and trust me, it's worth lowercasing the urls, if we didn't you'd be filing an issue for it

you really want regex routing, eh? lol