Comments (7)
It seems like npm has already solved this problem. Make axe-core
a peer dependency and everything will work as intended with the developers preferred version of axe-core
without any additional setup on their end.
Current consumers of the package should be able to continue using cy.injectAxe()
and cy.configureAxe()
in the same way they do today.
from cypress-axe.
Currently, axe-core is bundled within this library, so unless we change the build setup, the peer dependency approach won't work.
see: #37 (comment)
The proposed solution should work if we decide to keep the bundled approach. But, if we want to unbundle it; then, peer dependency should be enough.
from cypress-axe.
Now I see the problem! It's bundling all dependencies, which doesn't sound like an optimal solution:
Line 13 in ca7ac69
And looks like there were reasons to bundle it though I'm not sure what exactly was the problem:
from cypress-axe.
I've done some experiments on my project that uses cypress-axe.
When I try to use not bundled code, it fails with βfs.readFileSync is not a functionβ:
However, using axe.source
as suggested in #38 works fine.
I suggest we make a version with axe.source
without bundling and see what other problems folks may have.
from cypress-axe.
I've opened a pull request #69 β this works perfectly in my project. Would be great if anyone else could test it too.
from cypress-axe.
Thanks, @sapegin. I'm not sure either why @avanslaars decided to bundle it. If we can unbundle it, that will be great.
I tried PR #69 in my project and found an issue. Please see my comment here.
from cypress-axe.
π This issue has been resolved in version 0.9.0 π
The release is available on:
Your semantic-release bot π¦π
from cypress-axe.
Related Issues (20)
- Update plugin to be compatible with Cypress 11 HOT 3
- Resolved path for `axe.min.js` incorrect when using Cypress Component Testing (with Vite) and npm workspaces HOT 1
- Update plugin to be compatible with Cypress 12 HOT 1
- `aria-expanded` property seems to be missing, but appears in devtools HOT 1
- TypeError: Cannot read property 'run' of undefined at Context.eval
- Question: How to skip failures for some specific tags and throw errors for other tags? HOT 1
- how to config checkA11y for all tests HOT 1
- How to use the cypress-axe with component-testing (angular) HOT 7
- `cy.then() timed out after waiting 4000ms. Your callback function returned a promise that never resolved.` on some tests using `axe-core` 4.7.1. HOT 11
- Configure includedImpacts in cy.configureAxe instead of cy.checkA11y
- TypeError : Cannot read properties of undefined (reading 'run') HOT 3
- Documentation: missing configuration documentation
- Error while running the plugin in cypress HOT 2
- Update @cypress peer dependency with new version HOT 1
- consolidated a11y report
- Exclude color-contrast for disabled fields using disabled attribute.
- ReferenceError: require is not defined
- The 'task' event has not been registered in the setupNodeEvents method. You must register it before using cy.task() HOT 1
- Question: What is the difference between cypress-axe and jest-axe?
- Axe-core trademark use
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cypress-axe.