Comments (3)
Hello guys, sorry for joining the discussion here 🙏 .
how about on LoadService
we add the process to initialize the CustomLabel
to the empty value of map[string]string instead of leaving it nil ?
because most who use this compose-go
library call it in loader.Load()
. so when loader.Load()
return the Project
type the value of Service.CustomLabel
not nil but already initialize.
from compose-go.
cc @glours I know we talked about this before around another Compose PR, so you might remember some other cases we should track here
from compose-go.
Users should add new elements to this kind of Map with the helper Add
function that checks if the map is empty or not before adding a new value.
Anyway we can create a generic function for that as Golang 1.19 is out.
Golang 1.17 is not supported anymore so we may assume downstream projects to use at least Golang v1.18.x
from compose-go.
Related Issues (20)
- character '-' dash no longer valid environment variable HOT 5
- Invalid type of Published attribute in ServicePortConfig HOT 4
- Does not load from file with no content bytes.
- docker-compose with volume paths relative to respective config file paths HOT 2
- characters '[' and ']' can't be used in environment variable name
- Cannot marshal and unmarshal `types.Project` HOT 3
- Throttle device parsing problem
- Project name constraints only applied to `-p`, `name:` config property HOT 1
- `transformMappingOrList` makes wrong assumption that `value` is of `string` type and panics when it is not. HOT 1
- Potential typo in types.Resource Pids field name HOT 1
- Nested interpolation does not allow mixing of strings and variables, unless it ends with a variable
- Include functionailty does not actually use env files
- Service extensions do not following specification, needs clarification or correction
- Converting ports from short to long syntax should not assume "ingress" HOT 7
- Add an option to only warn about missing variables in `build` section HOT 1
- loader panic HOT 1
- panic: runtime error: invalid memory address or nil pointer dereference when docker-compose.yaml empty HOT 2
- Add Usage into README
- Project name not checked when using ToConfigFiles HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from compose-go.