Comments (7)
@naderman: There is a little issue here ;) For custom installers to be registered during install, or at all for that matter, we need to know which class in the package to run, like:
"extra": {
"class": "Symfony\\Bridge\\Composer\\BundleInstaller",
"file": "src/Symfony/Bridge/Composer/BundleInstaller.php"
}
The file entry would also be helpful otherwise we need to parse the autoload config at runtime, and that could prove complex.
What this means though obviously is that this class can't have any dependency, it'll just get a vendor directory, the download manager and the local repository injected, and has to be able deal with that. I'm not sure this will be sufficient, but I guess it's the only way, if people need more they probably will have to wrap composer into their framework/app to provide custom logic.
from composer.
Why can't we rely on the supplied auto loading information of that package? We don't have a generated autoloader yet, but we could register a very trivial PSR-0 autoloader based on the package contents right there and then?
from composer.
And regarding dependencies, I think that's fine. It'll be ok for that kind of an installer to load custom code in its implementation and make use of that.
from composer.
We can rely on the autoload info, it's just annoying to load that stuff inside the installer, we might need the "file" entry as optional anyway for packages that aren't autoloadable. Sounds reasonable?
from composer.
Can't we require that installers are always auto loadable?
from composer.
I'd just really like to keep our config options as minimal as possible.
from composer.
Sure we can do that too. I hope I can look into it this week.
from composer.
Related Issues (20)
- 'requirements-checker' does not run on windows HOT 1
- I can't install composer HOT 1
- Composer validate: keywords invalid value, must match regex HOT 3
- Composer install issue Cannot authenticate with bitbucket repository
- [feature] Add native NPM support HOT 3
- Windows 11/PHP8.3.3 install fails - missing or invalid info (exit code -1073741643) HOT 1
- Invalid package information: funding.1.url HOT 2
- Cannot install 3.0 with new Symfony project HOT 1
- Can't install certain composer packages without a proper .git directory. HOT 3
- [RFC] Automatically bump requirements when updating packages, with type=project or with an option in the configuration HOT 3
- TypeError with numeric environment variable
- Memory leak due to the copy of Metric objects in Composer's trainer HOT 2
- composer install shows progress despite --no-progress HOT 1
- Getting error HOT 2
- curl error 23 when updating custom repository HOT 20
- https://api.jikan.moe/v4/recommendations/anime HOT 1
- Ability to ignore platform check with autoloader HOT 1
- [Bitbucket] [AccessTokenAuth] File name too long HOT 3
- Plugin class in the project being created with `project-create` is not discovered HOT 5
- "clear-cache" ignores "cache-dir" defined in "composer.json"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from composer.