Use of `destroy` in `RdfJSQuadSource` possible cause of bugs.

[jeswr]

Use of `destroy` in `RdfJSQuadSource` possible cause of bugs.

[github-actions]

Thanks for reporting!

[jeswr]

I would suggest also replacing the following with it.emit('error', error); it.close():

• comunica/packages/actor-abstract-path/lib/PathVariableObjectIterator.ts

  Line 133 in c180fc6

  }, error => this.destroy(error));

• comunica/packages/actor-rdf-resolve-hypermedia-sparql/lib/RdfSourceSparql.ts

  Line 176 in c180fc6

  quads.destroy(new Error(`The endpoint ${this.url} failed to provide a binding for ${value.value}.`));

  
  At the same time I suggest tests be added to make sure that the streams can be consumed when necessary in error scenarios.

[rubensworks]

Note that AsyncIterator.destroy() was introduced to handle exactly these cases.
So if it doesn't do what we want it to do, then this is a design error in AsyncIterator.

The replacement you suggest is not the proper solution I believe, as calling .close() will still attempt to flush any buffered contents, while we can stop earlier (which is what .destroy() provides).

[rubensworks]

@jeswr Now that comunica/comunica-feature-link-traversal#95 has been resolved, ok to close this issue?

[rubensworks]

Closing this one. Feel free to re-open if still relevant in the future.