Giter Site home page Giter Site logo

Comments (5)

memsharded avatar memsharded commented on July 2, 2024

I am not sure, because conan_cmake_detect_gnu_libcxx checks for gcc flag _GLIBCXX_USE_CXX11_ABI which doesn't make much sense in clang. It also checks version against "5.1" to try to define libstdc++11 as the one being used.

So it might be necessary to add custom clang logic for this. I am fine with keeping _GLIBCXX_USE_CXX11_ABI as the flag to check if clangs ignores it.

from cmake-conan.

r4zzz4k avatar r4zzz4k commented on July 2, 2024

Sorry, I managed to miss your answer and forgot about the issue for a bit.
From what I see in libstdc++ documentation, all _GLIBCXX_ macros, including _GLIBCXX_USE_CXX11_ABI, are related to libstdc++, not to gcc toolchain. As clang also uses libstdc++, I believe it's okay to use mentioned macro to detect library version.

from cmake-conan.

memsharded avatar memsharded commented on July 2, 2024

Ok, got it, fixed it in #50, please have a look and report if necessary. Thanks!

from cmake-conan.

r4zzz4k avatar r4zzz4k commented on July 2, 2024

Cool! I'll try to pull new config and rebuild the project tomorrow, but I've made same changes locally (sorry for not providing proper PR).
Thanks once again for your great efforts!

from cmake-conan.

memsharded avatar memsharded commented on July 2, 2024

Thanks to you for the feedback, don't worry!
It is on master branch, I haven't created a proper release/tag for it, but if everything looks good, I'll create a new one.

from cmake-conan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.