Comments (5)
Using transfer
instead of internalTransfer
makes the CIS-5 standard incompatible with CIS-2, so I would suggest using some other name.
from concordium-rust-smart-contracts.
Using
transfer
instead ofinternalTransfer
makes the CIS-5 standard incompatible with CIS-2, so I would suggest using some other name.
Ah, right.. didn't think of that! Good point 👍
If the purpose is that these can be mixed, then maybe the transfer function should be prefixed with something that identifies this as a sc-wallet transfer? Can't figure out the best name just off the top of my head
from concordium-rust-smart-contracts.
Suggestion: cis5Transfer
for the name.
update: After a discussion, we realized that there is no function name overlap between CIS-2
and CIS-5
. CIS-5 will use as function names transferCCD /transferCIS2Token
.
from concordium-rust-smart-contracts.
It seems that the tests rely on cis2-multi
being compiled into ../cis2-multi/concordium-out/module.wasm.v1
. Maybe this should be added as a step in a build.rs
file when building tests? I don't know how well this plays with cargo-concordium
though.
from concordium-rust-smart-contracts.
It seems that the tests rely on
cis2-multi
being compiled into../cis2-multi/concordium-out/module.wasm.v1
. Maybe this should be added as a step in abuild.rs
file when building tests? I don't know how well this plays withcargo-concordium
though.
Let's discuss and create a separate issue for it. There are 3 contracts that have tests that depend on other contracts currently:
- sponsored-tx-enabled-auction
- cis5-smart-contract-wallet
- smart-contract-upgrade V1
The 'sponsored-tx-enabled-auction' and 'cis5-smart-contract-wallet' examples need the wasm module cis2-multi
for its tests.
https://github.com/Concordium/concordium-rust-smart-contracts/blob/main/.github/workflows/linter.yml#L901
The 'smart-contract-upgrade' example has a v1 and v2 contract and the tests in v1 needs the wasm module from v2 for upgrading.
https://github.com/Concordium/concordium-rust-smart-contracts/blob/main/.github/workflows/linter.yml#L896
from concordium-rust-smart-contracts.
Related Issues (20)
- Track and trace generic sponsored transaction service
- Smart Contracts: Common data structures
- Investigate cost-efficient ordered maps
- Expose Module Reference: concordium-std & testing library
- Templates do not build with the latest cargo-concordium Friday, March 1st
- Implement ordered map for smart contracts
- Add guide for choosing the right collection
- Templates do not build with the latest cargo-concordium cargo generate-generate 0.19.0
- Implement `Reject` trait for `CallContractError` so that they can be returned in entrypoint methods. HOT 4
- Make the `invoke_contract` public in `cis2client` so that custom methods can be called from cis2 contract. HOT 3
- Chaperone Smart Contract (Smart Contract Wallet Standard)
- Templates do not build with the latest cargo-concordium cargo generate-generate 0.20.0
- SchemaType for OnReceivingCis2DataParams does not match Serialize implementations HOT 1
- Remove redundant `serializationHelper` functions
- Create CIS-0 library and defined all `STANDARD_IDENTIFIER` constants in it HOT 1
- Templates do not build with the latest cargo-concordium cargo generate-generate 0.21.0
- Investigate smart contract components
- Update examples to use `module_load_output`
- [ deploy-scripts ] Add TLS support for node connection in the deployment script.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from concordium-rust-smart-contracts.