Wrong license discovered

[conda]

Wrong license discovered

[ocefpaf]

There is also the case of "aggressive" finding a license file. We should probably avoid looking into hidden directories. This is the case for sat-stac, a bad tarball with the .egg.

license_file: .eggs/pytest_runner-5.2-py3.8.egg/EGG-INFO/LICENSE

[marcelotrevisani]

all the packages mentioned are getting the right licence now
closing this for now, if you find another one, please open a new issue or reopen this please

[marcelotrevisani]

There is also the case of "aggressive" finding a license file. We should probably avoid looking into hidden directories. This is the case for sat-stac, a bad tarball with the .egg.

license_file: .eggs/pytest_runner-5.2-py3.8.egg/EGG-INFO/LICENSE

I thought I had removed the search in hidden folders. I will take a look on that later as well, thanks!

[ocefpaf]

Try sat-stac, if you don't get the bad license I may have an outdated version of grayskull.

PS: I'm working with upstream to fix it so you'll have to lock on the current version 0.4.0.

[maresb]

Here is a potentially really tricky case where a BSD 2-clause was interpreted as a 3-clause. Actual license file

[marcelotrevisani]

Here is a potentially really tricky case where a BSD 2-clause was interpreted as a 3-clause. Actual license file

indeed, the heuristic can be improved to discover the right licence. Currently, Grayskull is using a fuzzy matching system where it tries to compare the licence found in the project with the most common licences out there.