Non deterministic zookeeper.properties and myid files generation

[confluentinc]

Non deterministic zookeeper.properties and myid files generation

[sknop]

You are correct, I came across the same issue, which is caused by the Python dictionary not preserving the order.
I propose the following solution:
Add an artificial config item "id" into the hosts file, for example

zookeeper:
  hosts:
   zookeeper-01:
        zookeeper:
            id: 1
   zookeeper-02:
        zookeeper:
            id: 2

and change the zookeeper.properties.j2 in the following way:

# Maintained by Ansible
{% for key, value in zookeeper.config.items() %}
{{key}}={{value}}
{% endfor %}
{% for host in groups['zookeeper'] %}
{% set zookeeper_vars = hostvars[host].get('zookeeper', dict()) %}
{% set id = zookeeper_vars.get('id', loop.index) %}
server.{{ id }}={{ host }}:2888:3888
{% endfor %}

With this change, the old automatic assignment of ids is preserved, but if zookeeper.id is defined, it will be used instead.

[JumaX]

@sknop @michalklempa This has been addressed in the latest merged PR, #124