Infinite loop on retriable exception

[confluentinc]

Infinite loop on retriable exception

[ewencp]

@nirajpatel The loop always decrements remainingRetries by 1 and will always throw an exception once the remainingRetries has dipped below 0. This is probably not as common a pattern as using a while(true) with a required return/throw in the loop, but is effectively the same pattern.

[nirajpatel]

@ewencp oh okay, but it seems like the remainingRetries is being ignored altogether and there will be infinite retries. Is that on purpose? If so can you explain why?

[shikhar]

@nirajpatel remainingRetries is not ignored, it is used here:

kafka-connect-elasticsearch/src/main/java/io/confluent/connect/elasticsearch/bulk/BulkProcessor.java

Line 355 in 050cd6c

if (retriable && remainingRetries > 0) {

[nirajpatel]

I think I was testing that last night and the same requests kept failing over and over again but I might be wrong. I have my own version now that doesn't ever stop the entire connector on exception though so I won't be able to test it. Looks good though @shikhar. Great job on this code! The refactor is great.