[connect-fastify] issue running in google cloud / firebase functions

[Azuka]

[connect-fastify] issue running in google cloud / firebase functions

[timostamm]

Hey Azuka, thanks for raising the issue.

When you call done with a Readable, I expect fastify to set this value as the body property on the fastify request object. If I follow correctly, the Readable is passed as a parsedJsonBody: JsonValue to universalRequestFromNodeRequest() here.

I think to properly support this, we have to update the signature of universalRequestFromNodeRequest to explicitly handle this input, so that tests can be added.

I am not sure that we can modify the noop-parser without breaking other use cases. Adding good test coverage is not trivial, unfortunately. Maybe the best solution would be to allow you to bring your own content-type parser for firebase (in combination with updating the function signature).

We are currently switching our tests to https://github.com/connectrpc/conformance. This will possibly give us better options to add test coverage. For now, vendoring the plugin in your project seems like a good workaround.

[Azuka]

Thanks @timostamm.

I hadn't used fastify outside of firebase, but I agree about not breaking it for others without thorough tests.

I did go looking in the conformance repo before opening an issue (because I didn't see tests here), but glad to hear that there are plans to cover more use cases there.