Server should ignore duplicate requests

[connorkuehl]

Server should ignore duplicate requests

[wishawa]

Hello! I would like to work on this.

I'm still new to Rust and the TFTP protocol. So just to confirm my understanding:

• The case we want to handle here is when the RRQ/WRQ gets accidentally duplicated, right?
• We want to track the client's TID, which is the socket address we get from socket.recv_from(), is this correct?

Lastly, would an MPSC channel be more suitable than callback closure + ArcMutex? Server::serve can process all the finish messages from the Handlers upon receiving each new request.

[connorkuehl]

* The case we want to handle here is when the RRQ/WRQ gets accidentally duplicated, right?

Correct.

* We want to track the client's TID, which is the socket address we get from `socket.recv_from()`, is this correct?

Correct again!

Lastly, would an MPSC channel be more suitable than callback closure + ArcMutex? Server::serve can process all the finish messages from the Handlers upon receiving each new request.

Both approaches would certainly work; however, I dislike the idea of deferring all of that processing to the next invocation of the Server::serve method. Then the Server::serve method would come across as more of a Server::serve_and_update_ongoing_connections type thing. Using the ArcMutex would allow for updating the data structure on demand rather than waiting for the update to be taken off a queue. This also keeps the responsibility of various functions/methods narrower... does that seem reasonable?