Incorrectly decodes logs [2.x]

[consensys]

Incorrectly decodes logs [2.x]

[denisgranha]

Hi @krzkaczor !

22 is actually 34 in hex. Not sure where that 33 is coming from but the number seems correct? in etherscan is also displayed as 22

[krzkaczor]

@denisgranha thanks for the quick response! Yeah sorry, I meant 34 DEC anyway, the response that I am getting from the lib is totally different.

I pinned point the issue to BN.JS - the version that I have in my project incorrectly parses hex strings starting with 0x.

Are you able to confirm that it works for you?

I am gonna push the whole repository with repro in a sec.

[krzkaczor]

Its ready here: https://github.com/krzkaczor/abi-decoder-bug-repro

[denisgranha]

Hi @krzkaczor I was able to reproduce the bug, thank you for the report.

Will fix it soon

[krzkaczor]

My dummy fix would be to use this function to create BN instances rather than doing it directly:

function createBN(number) {
  // ensure to remove leading 0x for hex numbers
  if (typeof number === 'string' && number.startsWith("0x")) {
    number = number.slice(2);
  }
  return new BN(number);
}

[krzkaczor]

Thanks for quick fix! @denisgranha

Note: there are other calls to BN constuctor, do you think they are fine?

[krzkaczor]

Turns out that it still doesnt work correctly. My PR fixes it.

Stranger, if you're looking for a fix just use my fork.