Comments (5)
So to summarize - I'll only add the rewrite from "new-style anonymous functions" to old-style and a regression test which ensures that GetHintName
is static for both anonymous and explicit function.
from gnark.
@ivokub can you do a quick PR with
.init.funcN to ..glob.funcN
? And a non regression test; don't want to hit the same issue in another deployment.
--> I'm not sure #1043 isn't dangerous; it means circuits compiled before #1043 are not compatible with a process compiled post #1043 right ?
from gnark.
@ivokub can you do a quick PR with
.init.funcN to ..glob.funcN
? And a non regression test; don't want to hit the same issue in another deployment. --> I'm not sure #1043 isn't dangerous; it means circuits compiled before #1043 are not compatible with a process compiled post #1043 right ?
Indeed #1043 breaks compatibility between pre- and post 1043 circuits. So if we have a circuit compiled pre-1043, then solver/prover post-1043 fails as the hints are not found.
But still, I think 1043 is better for long-term as ensures more consistency. Instead of reverting I think it would better to add explicit hint overrides (for both Go <1.22 and =1.22 naming convention) to keep the backwards compatibility. I'd be happy to do it if makes sense.
from gnark.
Mmhhh no for the hint overhide, I think it's dirty ^^.
For Linea we can just recompile the circuits -- if that's the only change and the actual constraints are unchanged it's not a big issue.
from gnark.
Yup, didn't change the constraints. Only changed hints defined as
var Hint = func(mod *big.Int, inputs []*big.Int, outputs []*big.Int) error {
//
}
to
func Hint(mod *big.Int, inputs []*big.Int, outputs []*big.Int) error {
//
}
in std/algebra
packages.
from gnark.
Related Issues (20)
- Question: How to verify if a public witness is associated with certain public inputs? HOT 10
- bug: Proving Failed if builder.config.CompressThreshold is modified HOT 2
- How does gnark start GPU acceleration? HOT 1
- bug: BN254 mpcsetup "phase2Evaluations" file not encoded properly
- bug: document clearly that the hash function in `std/recursion` is not collision-resistant when inputs are of different length
- mpcsetup.InitPhase2 fails with 'panic: Number of constraints is larger than expected' HOT 1
- bug: use cryptographically strong hash function for checking if non-native element has to be width-constrained
- bug: describe in emulated `Reduce` method that the result may be either `x` or `x+p`
- bug: emulated `Exp` and `ModExp` take exponents as field elements
- bug: NAF decomposition doesn't enforce checks on adjacent values HOT 2
- chore: check rotation length in `uints` package method `Lrot`
- bug: subtraction padding in variable-modulus non-native arithmetic does not enforce underflow protection
- bug: restrict nbDigits in `std/math/bitslice` `Partition` method
- feat: allow avoiding commitments in non-native arithmetic using constant points for Schwartz-Zippel lemma HOT 5
- bug: AttachDebugInfo() contributes to most memory usage regardless of debug.Debug flag value
- feat: make `std/algebra/native/twistededwards` to implement `std/algebra.Curve` interface.
- Enable solidity scan on blockscout
- bug: Icicle integration is out of date HOT 1
- Question : Is to possible to read the Message field in human readable format inside the circuit
- Question : Is to possible to read the Message field in human readable format inside the circuit HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gnark.