interact_text on Windows 10 - Shift causes Custom Error

[Archina]

interact_text on Windows 10 - Shift causes Custom Error

[spenserblack]

I'm also still experiencing this (see console-rs/console#83 for issue I opened).

To reproduce here:

git clone https://github.com/mitsuhiko/dialoguer.git
cd dialoguer
git checkout 0.8.0
cargo run --example input
rem press shift key

[pksunkara]

We have some breaking changes in console which means it will take a bit more time to publish it so that we have more chance to include other breaking changes.

[Archina]

So i tried to trace down the bug further. It seems this derives from the dependency console. To be more detailed the key_from_key_code function in the windows_term.rs does not seem to handle winapi::um::winuser::VK_SHIFT => Key::Shift. Looking at the code however it seems okay to return Key::Unknown there. However, returning Ok(Key::Unknown) as well when self.is_tty is false seems wrong. It may be beneficial to instead return an actual Err in that case or to resort to an alternative enum value for Key.

Once that change has been made, this project could handle that error case appropriately.

Shall I open an issue at the console project as well?

[pksunkara]

Have you tried with latest dialouger 0.8.0?

[Archina]

I am quite sure that I was using the master branch for trying out the examples.

On my own project, I was using "0.8.0"

[pksunkara]

Fixed by console-rs/console#96

[lucasfernog]

Hey @mitsuhiko , nice work on this lib :) I love it and used it on several projects. When is this fix planned to be released?

Thank you :)

[Sloff]

I'm also experiencing this issue, using version 0.8.0