Comments (8)
Totally missed we hadn't done the fileheader fixup in this subproject; done in PR #129
from continuity.
Can we eliminate asm.s?
from continuity.
That file is distributed by the Go team, unmodified. The header is correct and accurate.
from continuity.
I think the point is that the file is distributed without license as header refers to license file, which is not the project's license.
Whether file is modified or not is irrelevant - either license allows modification.
from continuity.
There is no code distribution of the vendored content in most Golang-source projects. For properly understanding how vendored 3rd party licensing works, you need a tool like FOSSA which understands that dependency projects have their own code locations and licensing. Containerd has been FOSSA scanned and you can follow the link from the main containerd project to the FOSSA report to see 100s of dependent packages and their own code locations and licenses in their own projects.
There is no way for us to replicate each dependent project's license here in this project, nor will you find that in any other major Golang project (e.g. Docker, Kubernetes) as that is the nature of the "vendoring" model that is used by default in most Golang projects.
from continuity.
Also, I realize earlier comments were regarding temporary files waiting to be in the upstream golang.org/sys/x package; those files are no longer in our repository at all, so maybe this issue is moot now anyway?
Will close for now unless there are further developments here.
from continuity.
Dear Phil, thanks for feedback.
Also, I realize earlier comments were regarding temporary files waiting to be in the upstream golang.org/sys/x package; those files are no longer in our repository at all, so maybe this issue is moot now anyway?
Indeed, this file is gone.
The issue here is not about the vendor
directory, it's about the code of continuity.
Continuity comes with a license file, so I understand that the code is licensed under Apache 2.0. That is no problem. However license and copyright are two different things, and as of today there's still no explicit mention of copyright in continuity. None of the source file have a copyright mention.
I don't have permission to re-open the issue, but I believe it should be re-opened until this is fixed.
Thanks!
from continuity.
yeah this was two issues in one :-)
The remaining issue is that the source files (all of them) are missing the boilerplate copyright and license declaration. Incidentally said boilerplate is the way the apache license, itself, says to apply the license to the source. https://github.com/containerd/continuity/blob/master/LICENSE#L180-L201
Needs to be done before release?
from continuity.
Related Issues (20)
- Should os.ModeCharDevice be taken into account? HOT 2
- Empty files can diff as "modified" even when they're not HOT 1
- Errophone auto-generated constants, for Go standard library (gollvm) HOT 2
- Broken build on arm64 HOT 3
- TestUsage broken on ZFS HOT 2
- Should the default pathDriver walk though volume mount points on Windows? HOT 9
- fs.CopyFile should support copying metadata
- copyFileContent broken on zfs (in some cases)
- context.Resource generates unavoidable log-spam on Windows
- fs.CopyFile should use clonefile(2) on macOS when VOL_CAP_INT_CLONE is available
- Support GOOS=netbsd
- Fails to build with newer versions of golang-goprotobuf HOT 1
- Not connected... I guess? HOT 1
- Security vulnerabilities with spf13/cobra dependency HOT 7
- go.mod: update dependencies / CI failing HOT 1
- Continuity is failing to ignore unsupported xattrs on Windows
- Add CI coverage for more filesystems
- clonefile() should fall back to copyfile() for cross-device copying
- [Darwin] clonefile() fails if the target already exists HOT 1
- `continuity.context.Walk` assumes incorrect behavior for `os.Readlink`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from continuity.