Comments (12)
@yanxuean Are you interested in this? We could start from a simple PR, just put container/sandbox metadata into container label when create container.
from cri.
@Random-Liu Ok.
from cri.
Just FYI. We could leverage containerd/containerd#1378 to store our metadata.
from cri.
@yanxuean thanks for offering help with this. Let us know if you got a chance to take a look at it and if you need any help from us.
from cri.
OK. I'm studying the RunPodSandbox function now. If there is a need I will.
@Random-Liu Do you means that we should put sandboxstore.Sandbox into containers.Container.extensions by json string?
from cri.
@yanxuean sandboxstore.Sandbox.Metadata
and sandbox.Container.Metadata
.
And if we use the new extensions
, we don't need to convert it to json. Just put the type into Any
direclty.
from cri.
@yanxuean How's going? The first step is relatively straight forward, but this feature itself is important to this release. :) If you haven't got a chance to look at this, we have to start working on this now. :)
from cri.
@Random-Liu I modified it, and I'm testing it, but it always is fail.
because containerd/containerd#1378 has not commited, I merge it on local(api/next.pb.txt, containers.proto, container.go), and add withextension function.
I'm analyzing the reason.
from cri.
@yanxuean Could you add them to container labels for the first version? So that we could start consuming that information.
After containerd/containerd#1378 is merged, we could leverage it, but the restart recovery logic won't be affected. :)
from cri.
@Random-Liu OK, I modify it today
from cri.
@yanxuean Thanks!
from cri.
Reopen since this is not finished yet.
from cri.
Related Issues (20)
- Problems with exec - differences between dockershim and containerd
- Release tarballs for v1.3.5 and v1.3.6 not published HOT 9
- please delete
- Latest Windows runner in github actions is failing HOT 2
- Pods stuck in container creating on enabling CNI chaining HOT 8
- container list pod id filter should support short pod id
- containerd.service should be pulled from containerd repo HOT 2
- Support for ephemeral containers .. NamespaceMode=Target HOT 2
- Unable to pull image from Insecure Registry on GKE HOT 14
- Some nodes on GKE giving archive/tar: invalid tar header: unknown HOT 5
- Default values for masked and readonly paths are not used for container creation
- Pod stuck Terminated always util `ctr t rm {}` HOT 1
- containerd config default brings old config that gives warning in daemon HOT 1
- Trying to redirect to a different path on a alternative registry HOT 8
- Help need to add a private registry to containerd / k3s HOT 2
- archive docs and point to new location
- mirror and tls configuration are mutually exclusive HOT 1
- golang 1.6
- contain-nerd-B4L HOT 3
- StopContainer silently ignored when container is in CONTAINER_CREATED state HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cri.