Giter Site home page Giter Site logo

Comments (12)

Random-Liu avatar Random-Liu commented on August 25, 2024

@yanxuean Are you interested in this? We could start from a simple PR, just put container/sandbox metadata into container label when create container.

from cri.

yanxuean avatar yanxuean commented on August 25, 2024

@Random-Liu Ok.

from cri.

Random-Liu avatar Random-Liu commented on August 25, 2024

Just FYI. We could leverage containerd/containerd#1378 to store our metadata.

from cri.

abhi avatar abhi commented on August 25, 2024

@yanxuean thanks for offering help with this. Let us know if you got a chance to take a look at it and if you need any help from us.

from cri.

yanxuean avatar yanxuean commented on August 25, 2024

OK. I'm studying the RunPodSandbox function now. If there is a need I will.
@Random-Liu Do you means that we should put sandboxstore.Sandbox into containers.Container.extensions by json string?

from cri.

Random-Liu avatar Random-Liu commented on August 25, 2024

@yanxuean sandboxstore.Sandbox.Metadata and sandbox.Container.Metadata.

And if we use the new extensions, we don't need to convert it to json. Just put the type into Any direclty.

from cri.

Random-Liu avatar Random-Liu commented on August 25, 2024

@yanxuean How's going? The first step is relatively straight forward, but this feature itself is important to this release. :) If you haven't got a chance to look at this, we have to start working on this now. :)

from cri.

yanxuean avatar yanxuean commented on August 25, 2024

@Random-Liu I modified it, and I'm testing it, but it always is fail.
because containerd/containerd#1378 has not commited, I merge it on local(api/next.pb.txt, containers.proto, container.go), and add withextension function.
I'm analyzing the reason.

from cri.

Random-Liu avatar Random-Liu commented on August 25, 2024

@yanxuean Could you add them to container labels for the first version? So that we could start consuming that information.

After containerd/containerd#1378 is merged, we could leverage it, but the restart recovery logic won't be affected. :)

from cri.

yanxuean avatar yanxuean commented on August 25, 2024

@Random-Liu OK, I modify it today

from cri.

Random-Liu avatar Random-Liu commented on August 25, 2024

@yanxuean Thanks!

from cri.

Random-Liu avatar Random-Liu commented on August 25, 2024

Reopen since this is not finished yet.

from cri.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.