Comments (10)
Because we want to make sure that we get at least version 5.4.5 of swiftmailer/swiftmailer
. There has been a major security issue in version < 5.4.5.
from standard-edition.
Got it. So should this be the same in the manager-bundle, then?
https://github.com/contao/manager-bundle/blob/develop/composer.json#L16
from standard-edition.
No, it is already in the core bundle: https://github.com/contao/core-bundle/blob/master/composer.json#L41
from standard-edition.
I don't want to poke around on this, just to get a better understanding of the whole thing 😉: If for some reason the requirement of a version > 5.4.5 can not be fulfilled, wouldn't this just install an old version of the standard-edition (4.3.1) then? I think that's the reason why the requirement was not raised in the symfony bundle.
see symfony/swiftmailer-bundle#156
from standard-edition.
No, it would exit saying "your requirements could not be resolved to an installable set of packages".
from standard-edition.
from standard-edition.
Because we want to make sure that we get at least version 5.4.5 of
swiftmailer/swiftmailer
.
Couldn’t this also be done by adding a conflict for "swiftmailer/swiftmailer":"<5.4.5"
?
from standard-edition.
Probably yes, I'll try it.
from standard-edition.
That's exactly how e.g. https://github.com/Roave/SecurityAdvisories works. Maybe it does make sense to use such solution in general. I wonder if this would increase the complexity to calculate dependencies, though.
from standard-edition.
Changed in contao/core-bundle@4048d8b.
from standard-edition.
Related Issues (20)
- Change /web to /public_html HOT 1
- Wartungsmodus nicht möglich HOT 6
- Unable to login when behind a SSL Proxy HOT 7
- Add basic security HOT 20
- Do not ship a default .htaccess file HOT 14
- Fehler beim Aufruf der Install.php - 4.3.6 HOT 4
- Manger Bundle in composer.json HOT 7
- Speichern und zurück funktioniert nicht mehr HOT 3
- Breaking change in Symfony Filesystem HOT 2
- Safari kann die Seite nicht öffnen, da die Netzwerkverbindung unterbrochen wurde HOT 7
- Fehler nach Installation unter XAMPP HOT 3
- Attempted to load class \"Config\" from the global namespace. HOT 25
- Unification of contao parameters HOT 1
- Alias Generierung HOT 1
- pages can not be selected in the pagebrowser. Radio buttons are missing. HOT 1
- cacheWarmup for "setup-scripts" HOT 5
- Maintenance "Recreate the symlinks" fails HOT 1
- Unattended Install HOT 8
- cacheWarmup differences between managed-edition? HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from standard-edition.