Giter Site home page Giter Site logo

Comments (8)

n1ru4l avatar n1ru4l commented on June 3, 2024 3

Fix is being worked on in #91

from graphql-helix.

mcrawshaw avatar mcrawshaw commented on June 3, 2024 3

Confirmed as resolved in 0.9.1.

from graphql-helix.

n1ru4l avatar n1ru4l commented on June 3, 2024 2

🎉

from graphql-helix.

hayes avatar hayes commented on June 3, 2024

this is related to execute removing support for positional args.

Args for execute were converted to be an object, but they key for context should have been updated to be contextValue but is being passed as context

c8750f3#diff-6c8aa63d319597d6d7fff26fda262c760963d5a73d99ad303c0da528bbd376a5R140

Technically this was also a breaking change since any provided context function is now called with completely different arguments.

I think it would probably also make sense to align formatResult with this new API so both are called with contextValue to keep things consistent (this is also a breaking change)

from graphql-helix.

hayes avatar hayes commented on June 3, 2024

Happy to submit an PR if you want, just need to know how to resolve this (which combination of the following fixes makes sense).

  1. Just call execute with the contextValue
  2. Update types for custom execute function to accept same arg shape as default execute
  3. Map old execute format to new execute format so API does not change
  4. Update formatPayload to also accept context as contextValue

from graphql-helix.

dotansimha avatar dotansimha commented on June 3, 2024

@ardatan can you please check this?

from graphql-helix.

ilijaNL avatar ilijaNL commented on June 3, 2024

Confirmed this. It also breaks usage with getEveloped (https://github.com/dotansimha/envelop)

from graphql-helix.

bigint avatar bigint commented on June 3, 2024

Working perfect now thanks!

from graphql-helix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.