Comments (6)
I have to test this out.
I think there is a bug that when there is a tag v0.2.2 the bump pre-release should always be 0.2.3-rc.1 or 0.3.0-rc1.
I am not sure what should be the behavior if there are no fix/feat or breaking changes.
from convco.
I think that in this case the issue is that there is no commit that increments the version by convention.
Maybe in this case, there should exit with an error, or it should bump to the next patch release?
from convco.
Is there a way to add/introduce custom config so that parse other commits used as patch/minor/major?
from convco.
Additional types are not mandated by the Conventional Commits specification, and have no implicit effect in Semantic Versioning (unless they include a BREAKING CHANGE)
Not implemented as not in the spec.
from convco.
Sorry to answer late, but i don't have much free time.
I see indeed that it does not do what is expected.
#!/bin/env sh
set -x
rm -rf .git
convco version
git init .
convco version
git commit --allow-empty -m 'hotfix: correct ..'
convco version
git tag v0.2.2
convco version
git commit --allow-empty -m 'chore: release'
git commit --allow-empty -m 'perf: use precompiled binary'
convco version --bump --prerelease rc
The last output is indeed 0.2.2-rc.1
where this should be 0.2.3-rc.1
as 0.2.2
has already been released.
I will debug further and try to fix it
from convco.
For point 7 I cannot reproduce.
Which version of convco do you use @kaankoken ?
#!/bin/env sh
set -x
rm -rf .git
convco version
git init .
convco version
git commit --allow-empty -m 'hotfix: correct ..'
convco version
git tag v0.2.2
convco version
git commit --allow-empty -m 'chore: release'
git commit --allow-empty -m 'perf: use precompiled binary'
convco version --bump --prerelease rc
git tag "v$(convco version --bump --prerelease rc)"
convco version
git commit --allow-empty -m 'fix: test'
convco version --bump --prerelease rc
git tag "v$(convco version --bump --prerelease rc)"
git commit --allow-empty -m 'fix: test'
convco version
The last command prints 0.2.3-rc.1
as expected.
from convco.
Related Issues (20)
- Option to strip a given prefix pattern from commit message before determining the version HOT 4
- Documentation on pre-release HOT 1
- `convco check --from-stdin` has zero exit code on failure HOT 1
- v0.4.1 --from-stdin regression HOT 5
- Improve releasing HOT 4
- Missing release assets for macOS and Linux in v0.4.2 HOT 2
- bug: `convco commit` allows invalid scopes HOT 9
- Consider warning user if `convco commit` is run without any staged files HOT 4
- Improve patch and intent to add
- Default YAML file unavailable HOT 2
- Display commit revision for latest Tag, or first commit HOT 3
- feat: support COMMIT_EDITMSG HOT 7
- [FEAT] Support path globs for `convco version --path` HOT 6
- Better Documentation for using convco as git editor HOT 2
- Tag which is being ignored HOT 2
- a repository with sparse-checkout fails HOT 2
- `check` documents `--merges` for `changelog` HOT 1
- areas for performance improvements HOT 3
- Arrow keys not supported for moving cursor in dialoguer input HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from convco.