Giter Site home page Giter Site logo

Comments (6)

hdevalke avatar hdevalke commented on September 28, 2024 1

I have to test this out.

I think there is a bug that when there is a tag v0.2.2 the bump pre-release should always be 0.2.3-rc.1 or 0.3.0-rc1.

I am not sure what should be the behavior if there are no fix/feat or breaking changes.

from convco.

hdevalke avatar hdevalke commented on September 28, 2024 1

I think that in this case the issue is that there is no commit that increments the version by convention.
Maybe in this case, there should exit with an error, or it should bump to the next patch release?

from convco.

kaankoken avatar kaankoken commented on September 28, 2024

Is there a way to add/introduce custom config so that parse other commits used as patch/minor/major?

from convco.

hdevalke avatar hdevalke commented on September 28, 2024

Additional types are not mandated by the Conventional Commits specification, and have no implicit effect in Semantic Versioning (unless they include a BREAKING CHANGE)

Not implemented as not in the spec.

from convco.

hdevalke avatar hdevalke commented on September 28, 2024

Sorry to answer late, but i don't have much free time.
I see indeed that it does not do what is expected.

#!/bin/env sh
set -x
rm -rf .git
convco version
git init .
convco version
git commit --allow-empty -m 'hotfix: correct ..'
convco version
git tag v0.2.2
convco version
git commit --allow-empty -m 'chore: release'
git commit --allow-empty -m 'perf: use precompiled binary'
convco version --bump --prerelease rc

The last output is indeed 0.2.2-rc.1 where this should be 0.2.3-rc.1 as 0.2.2 has already been released.
I will debug further and try to fix it

from convco.

hdevalke avatar hdevalke commented on September 28, 2024

For point 7 I cannot reproduce.
Which version of convco do you use @kaankoken ?

#!/bin/env sh
set -x
rm -rf .git
convco version
git init .
convco version
git commit --allow-empty -m 'hotfix: correct ..'
convco version
git tag v0.2.2
convco version
git commit --allow-empty -m 'chore: release'
git commit --allow-empty -m 'perf: use precompiled binary'
convco version --bump --prerelease rc
git tag "v$(convco version --bump --prerelease rc)"
convco version
git commit --allow-empty -m 'fix: test'
convco version --bump --prerelease rc
git tag "v$(convco version --bump --prerelease rc)"
git commit --allow-empty -m 'fix: test'
convco version

The last command prints 0.2.3-rc.1 as expected.

from convco.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.