Giter Site home page Giter Site logo

Comments (3)

knocte avatar knocte commented on June 9, 2024 1

according to https://www.conventionalcommits.org/en/v1.0.0/#specification

I don't think the spec is disallowing dashes here, cannot a noun include a dash? for example: fix(well-being): some title. In this case, the noun is compound.

I know I hand-picked an example on purpose to make my point, and it sounds like "well-being" might not be a usual scope. However, a scope normally refers/maps to a folder or project in the repo, and why wouldn't folders contain dashes?

I disagree that this is a bug. If you want to enforce scopes to not have dashes on your side, you could create a custom rule via plugins.

from commitlint.

knocte avatar knocte commented on June 9, 2024 1

I know I hand-picked an example on purpose to make my point, and it sounds like "well-being" might not be a usual scope.

Actually, it's much simpler to come up with a better example. Let's say we fix something in this repo itself in the config-angular folder: the scope might become config-angular.

from commitlint.

DrummyFloyd avatar DrummyFloyd commented on June 9, 2024 1

yes i get you point, @knocte =)
it's just that i use many tools based on conventionnal commit , and when i used something with a - in it , some of the tools need to be tweak.

your explanation is totally right , but i prefered to raised an issue , like this ppl will be aware of that in case of =)
and i think when you use an hyphen noun, is not just a simple noun but it's a compound noun , not quite the same =/

tbh: i'm fully agree with you , config-angular should be totally right =)

from commitlint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.