Support more than just numeric issue IDs

[cookpete]

Support more than just numeric issue IDs

[cookpete]

--issue-pattern option added in 1.3.0. See docs here. 👍

[cookpete]

This is a decent idea. Is the convention to use a hash, like fixes #ABC-12343 or just fixes ABC-12345?

Maybe issues like this should only be parsed if you set a custom issueUrl, otherwise the default issue links are guaranteed to not be correct.

[jeffkpayne]

I think using the same #... convention is reasonable. The Atlassian suite will parse its own issue keys without the # and add links automatically, but it makes sense to me that the convention you use is consistent.

Wrt when you would use the alternate ID regex logic, why not allow the user to specify it? That way you could leave it up to the user to use a regex that matches their particular ticket ID and issue URL scheme.

[cookpete]

Wrt when you would use the alternate ID regex logic, why not allow the user to specify it?

Yeah this makes sense. Then it's down to the user to manage any pitfalls that may come up.

[cookpete]

One concern is that we would lose the fixes/resolves/closes pattern that is currently built in. If a user provided [A-Z]+-\d+ as the issue pattern then it might be too aggressive, ie

This commit is not related to PROJECT-123 

And has nothing to do with the serial number QWIODWJQO-014987298
And also does something to fix CAT-5 ethernet cables

would parse PROJECT-123, QWIODWJQO-014987298 and CAT-5 as a fix.

[jeffkpayne]

Right, the user would have to make sure to include the `#` characters at the beginning of the regex to differentiate those IDs. You could also have a predefined set of popular regex patterns that would handle 95% of the use cases.

On Fri, Dec 8, 2017, 6:20 AM Pete Cook ***@***.***> wrote: One concern is that we would lose the fixes/resolves/closes pattern that is currently built in. If a user provided [A-Z]+-\d+ as the issue pattern then it might be too aggressive, ie This commit is not related to PROJECT-123 And has nothing to do with the serial number QWIODWJQO-014987298 And also does something to fix CAT-5 ethernet cables would parse PROJECT-123, QWIODWJQO-014987298 and CAT-5 as a fix. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#18 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACoMfHzJsuiYAf89zZPsSIi9XXaOpdDks5s-UWigaJpZM4Q4bkh> .

-- Jeff Payne [email protected] 916-273-0938