Close/Open Comments

[coralproject]

Close/Open Comments

[wyattjoh]

I added a comment on a related PR: #161 (comment)

I just don't think that an asset holds the same responsibilities that a comment has, so I don't think that we necessarily need to break out the functionality from the closedAt field already provides

The status of a asset is based on a temporal value (the time) and not the "most recent status" so the determination of the current status becomes much more complex on the FE and the BE

If this were just a text field of status (like in the comment) I'd agree that it would work. But the closed status doesn't make sense that we "need" to store the history especially because of the overhead of managing the data models for it.

I just don't think this is the right approach.

[gabelula]

How do you open back the asset with the closedAt approach? Just null back the field? I'm ok with that for now actually. We just needed to fix the backend to have it working with the frontend. I can modify the PR for that.

@jde any thoughts about this?

[wyattjoh]

closedAt: null or closedAt: false would do the same thing there I think @gabelula

[gabelula]

It get resolved in the PR #161 ready for review.