Giter Site home page Giter Site logo

Comments (4)

awelzel avatar awelzel commented on June 11, 2024 2

@AlyaGomaa , very nice catch!

i guess this means that suricata is the one doing something wrong, and not pycommunityid?

It looks like, yes. I moved it over to the Suricata project:
https://redmine.openinfosecfoundation.org/issues/6276
https://github.com/OISF/suricata/pull/9399/files

(I don't have permissions to close the issue - maybe you could yourself?)

from pycommunityid.

ckreibich avatar ckreibich commented on June 11, 2024 1

Thanks again for this from me too — very helpful. Your finding made me realize an omission in the test data over in https://github.com/corelight/community-id-spec — the test traces have only individual flows (for example just one for IPv6 traffic), so they don't fully cover the endpoint-flipping logic if you only report per-flow Community IDs. I remember briefly comparing the Zeek and Suricata implementations with those traces and, seeing that they matched, moving on. But that was very incomplete...

from pycommunityid.

AlyaGomaa avatar AlyaGomaa commented on June 11, 2024 1

hey @ckreibich we've all been there, glad i could help!

from pycommunityid.

AlyaGomaa avatar AlyaGomaa commented on June 11, 2024

Hey thanks for your help! will close.

from pycommunityid.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.