Comments (3)
Neat, I didn't know about https://httpbin.org/.
There's a potential optimization we could do on OSTree-based systems for files in /etc
: there's already a backup of the shipped file in /usr/etc
. Though there are some instance-specific files that don't have such a backup, e.g. /etc/fstab
. But we could easily detect those by the fact that they're not in /usr/etc
.
I'll just also mention that making append operations idempotent is also relevant for other software that handle Ignition configs like the machine config daemon (though right now it just sorta assumes that it won't be handed a config that asks for appending files).
from ignition.
@bgilbert The proposed fix would help, but wouldn't completely fix the problem. If something fails during or after deleting the .orig
files then we have the same problem.
@jlebon we'd need to bake the logic into ignition to append from /usr/etc
to /etc
but just on ostree systems. I'm not fanatical about that. I'd rather just redeploy the root if Ignition failed. It also still leaves us with the same problem on /var or any secondary filesystems.
from ignition.
The assumption was that nothing would fail after the commit point. The approach isn't bulletproof, but would at least address Ignition config problems and transient network conditions.
I agree that the ostree-specific logic doesn't seem worth it.
from ignition.
Related Issues (20)
- Dracut module installation fails on Ignition 2.16.1 on ppc64le and s390x
- Release 2.16.2 HOT 2
- Consider adding a configuration knob to disable Ignition logging
- disks stage failure without visible error HOT 2
- Custom AMI doesn't run ignition when used HOT 1
- Support encrypting LUKS devices using CEX secure keys on s390x HOT 24
- Support for importing public SSH keys from GitHub
- Swap fails to mount due to a race condition HOT 2
- Prevent modification of partitions/devices in use HOT 1
- Release v2.17.0 HOT 3
- [packit] Invalid config HOT 1
- Support for encrypted inline file content
- Migrate to `aws-sdk-go-v2`
- Remove linear RAID as an option HOT 1
- Retry on HTTP 410 error code for Azure IMDS provider
- Release 2.18.0 HOT 1
- Dropins wrong file permissions HOT 4
- Disk label changes on reboot HOT 5
- Add ignition to CoreOS version compatibility mappings HOT 1
- Ignition on Windows VirtualBox failed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ignition.