[FEAT] Comparison for different users or service accounts

[corneliusweig]

[FEAT] Comparison for different users or service accounts

[corneliusweig]

Hi Piotr, this is a nice idea. I tried whether wdiff would give acceptable results, but it doesn't, because it messes up the table format. So it is not a task that can be done easily by combining existing tools.

For this to work, I need to restructure the code somewhat. I would do many things differently today, and I want the code to be more maintainable long-term.

[corneliusweig]

How about this format (with colors):

$ rakkess diff -n kube-system --sa=coredns sa=attachdetach-controller
NAME                    LIST  CREATE  UPDATE  DELETE
endpoints               ◀                     
events                        ▶       ▶       
events.events.k8s.io          ▶       ▶       
persistentvolumeclaims  ▶                     
services                ◀

Left will be the original access settings (here SA coredns), right is the patched one (here SA attachdetach-controller).

WDYT?

[piotrminkina]

Hello @corneliusweig

Thanks for your interest in my proposal, I see a lot of work being done here. Unfortunately, I do not understand what the triangles and blanks mean. Maybe the colours you write about would explain something more, but no any colors with your example :)

Regards

[corneliusweig]

The arrows are supposed to indicate if a a given verb is allowed for the resource. For example
same for both configs
◀ The original config can access, but not the modified one
▶ The modified config can access, but not the original one

The idea is to highlight the diff between the two configs.

---

However, your reaction tells me that the given CLI does not work. I think a better syntax is

rakkess diff --left=--sa=coredns --right=--sa=attachdetach-controller