Giter Site home page Giter Site logo

Comments (5)

stevenylt avatar stevenylt commented on August 15, 2024 2

tools: [
{
name: "HelloWorldMouse",
mode: "active",
toolClass: HelloWorldMouseTool,
modeOptions: { mouseButtonMask: 1 }
},
]

from react-cornerstone-viewport.

stevenylt avatar stevenylt commented on August 15, 2024 1

I figured out. Add toolClass property in the tools definition inside state. Working now. Thanks

from react-cornerstone-viewport.

dannyrb avatar dannyrb commented on August 15, 2024

If you spin up a reproduction in CodeSandbox, I can look into the issue.

This is the portion of the component responsible for handling the tools prop: https://github.com/cornerstonejs/react-cornerstone-viewport/blob/master/src/CornerstoneViewport/CornerstoneViewport.js#L749-L781

It looks like if a name is specified, we try to find the matching tool clas from the top level exports of cornerstone-tools. If the toolClass property is provided, we use that instead of trying to find by name.

If you think there's a friendlier or expected approach here, let me know. All for simplifying/improving the API.

from react-cornerstone-viewport.

stevenylt avatar stevenylt commented on August 15, 2024

I found it is caused by this section of code:

function _addAndConfigureInitialToolsForElement(tools, element) {
for (let i = 0; i < tools.length; i++) {
const tool =
typeof tools[i] === "string"
? { name: tools[i] }
: Object.assign({}, tools[i]);
const toolName = ${tool.name}Tool; // Top level CornerstoneTools follow this pattern

tool.toolClass = tool.toolClass || cornerstoneTools[toolName];

if (!tool.toolClass) {
  console.warn(`Unable to add tool with name '${tool.name}'.`);
  continue;
}

It somehow couldn't find toolClass. Where do I set the toolClass value for the custom tool?

from react-cornerstone-viewport.

HubertChau avatar HubertChau commented on August 15, 2024

Hey i'm running into the same issue and have attempted your solution of adding a toolClass element to the tool array however it doesn't appear to work. I might be importing the customTools incorrectly:
"import HelloWorldMouseTool from './tools/customTools'"

from react-cornerstone-viewport.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.