Giter Site home page Giter Site logo

eth_mac_10g_fifo.v minor bug about corundum HOT 4 CLOSED

corundum avatar corundum commented on July 24, 2024
eth_mac_10g_fifo.v minor bug

from corundum.

Comments (4)

alexforencich avatar alexforencich commented on July 24, 2024 1

For simple changes like this, it's best to just let me know and then I will deal with it correctly. Some of these simple fixes - especially fixes in example designs - can also affect multiple files due to code duplication, so if your PR doesn't fix all of them in one shot then I would just do it myself anyway for consistency.

And yes, I will update the Ethernet code in here when it makes sense to do so, after verifying that those changes don't break anything.

from corundum.

alexforencich avatar alexforencich commented on July 24, 2024

Yes, I think you are correct about that, I will fix that in the verilog-ethernet codebase.

from corundum.

adi8v avatar adi8v commented on July 24, 2024

Ok, great. I didn't know whether to do a pull request or leave it to you. Do you periodically merge the verilog-ethernet codebase across to Corrundum?

from corundum.

alexforencich avatar alexforencich commented on July 24, 2024

I forgot to mention that I merged the fix for this in back in February. But, the latest set of changes move the async FIFOs into the new core logic modules, so the eth_mac_10g_fifo module is actually no longer used in Corundum; the eth_mac_10g module is used instead with separate FIFOs.

from corundum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.