Giter Site home page Giter Site logo

Comments (5)

davidtheclark avatar davidtheclark commented on May 29, 2024 1

I think defaulting searchPath to process.cwd() seems right. So explorer.load() is the equivalent of explorer.load(proces.cwd()). Let's do that, unless anyone objects.

from cosmiconfig.

sudo-suhas avatar sudo-suhas commented on May 29, 2024 1

Fixed and released in [email protected] ๐ŸŽ‰

from cosmiconfig.

sudo-suhas avatar sudo-suhas commented on May 29, 2024

@montogeek I think you are right. process.cwd() is used if the second parameter to createExplorer.load, configPath is specified(resolved relative to it). Otherwise, the searchPath is resolved relative to process.cwd. But I am not entirely sure if we should update the docs or the code. Defaulting the searchPath to process.cwd() makes sense but I am wondering if we are missing some edge case scenario.

@davidtheclark, thoughts?

from cosmiconfig.

sudo-suhas avatar sudo-suhas commented on May 29, 2024

@davidtheclark Could you please take a look at this issue? I'd like to resolve this before releasing 4.0.

from cosmiconfig.

montogeek avatar montogeek commented on May 29, 2024

Thanks!

from cosmiconfig.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.