JS config never gets garbage collected.

[cosmiconfig]

JS config never gets garbage collected.

[SevInf]

Ok, so far I've submitted a patch to require-from-string, doing the cleanup: floatdrop/require-from-string#9.

I'm still not entirely sure it belongs there, let's see what maintainers say. But if it won't be merged, I think we still can continue to use require-from-string and do this cleanup in cosmiconfig instead.

[sudo-suhas]

Fixed and released in 3.0.1 🎉

[davidtheclark]

That's a bummer and also very interesting, @SevInf. Thanks for investigating it. Do you have any recommendations that might fix it?

[sudo-suhas]

Thanks for investigating it

+1 from me as well.

Is this a bug in require-from-string or is the problem related to how cosmiconfig uses it?

[SevInf]

@davidtheclark it looks like replacing require-from-string with something like import-fresh fixes it. I can send pull request tomorrow.

@sudo-suhas from require-from-string point of view, I think, this behavior is correct, it just might not align that well with cosmiconfig.

[sudo-suhas]

Thanks @SevInf. Isn't import-from more suited to the purpose than import-fresh?

[sudo-suhas]

Sorry. Closed by mistake.

[SevInf]

@sudo-suhas I think by the time it gets to loadJs cosmiconfig have already figured out the absolute path to the file, so import-from won't add anything new to a plain require here.

I assumed require-from-string is used instead of require to bypass require.cache. Is it true? If so, import-fresh will preserve this behavior.

[sudo-suhas]

Honestly not too sure. Perhaps @davidtheclark can clarify. AFAIK there is no intent to bypass require.cache. Also see sindresorhus/import-from#4 (comment).

[davidtheclark]

@SevInf @sudo-suhas: For a little background you can read #21 and #51.

The summary: We were using require-from-string because it allowed us to avoid reading the file multiple times and to stay asynchronous. Those are the things we would sacrifice, I think, if we switched to require. What do you think about the trade-offs?

[sudo-suhas]

I tried to upgrade deps so that this issue would be fixed. However, faced an issue due to jest + require-from-string which is failing a lot of tests. Have created a PR floatdrop/require-from-string#10 which will fix the issue.