Countly installs a non-compliant polyfill for Element.closest

[countly]

Countly installs a non-compliant polyfill for Element.closest

[morungos]

The problematic line is:

countly-sdk-web/lib/countly.js

Line 3225 in e4d6514

Element.prototype.closest = function(nodeName) {

[morungos]

I am happy to provide a pull request to address this, or simply wait to hear back on it.

[iartem]

Ok, let's give it a push 😄 @ArtursKadikis

[ArtursKadikis]

you probably meant @ar2rsawseen 😃

[ar2rsawseen]

Hello @morungos
currently, we are actually in between developers and looking for a new developer to fill in this position. So that's why some things have stopped here.
But if you can make a PR, that would be great, I can merge and release it :)

[morungos]

Excellent. I've built an initial pass at a polyfill that preserves all the IE11 goodness from the MDN polyfill, but falls back to current behaviour when it's missing. It looks right, but I'll test on an IE11 to be safe, and I should be able to assemble the PR later today. I don't think I can easily automate tests for polyfill since it looks like the current setup probably provides the missing function anyways.

I might need a few pointers/tweaks as to the build (or you may wish to add that) as I can't see from the code how the .min.js gets updated (the webpack config refers to a .pack.js), and the tests are failing for me too (there's some warnings about phantomjs on a new macOS, but some of the differences are environmental too: failing between my en-CA and the expected en-US locale.

[ar2rsawseen]

Hello, yeah, you don't have to worry about those, we will handle it internally, that is part of the build process :)
and with the change of developer we will be also revamping tests, etc.

[ar2rsawseen]

Should be fixed here:
fb14912