Country definition in wrong case

[countries]

Country definition in wrong case

[scudco]

@auzroz you are right about this. The ISO spec uses uppercase and so should this gem. This would be a breaking change for anyone who currently has lowercase values persisted in a database so it'll probably take adding option to the view helper to allow uppercase support. Does that sound reasonable to you? In the next major release I think we're moving to iso codes on by default and it sounds like uppercase should be on by default as well.

[stefanpenner]

@scudco 👍

[auzroz]

As a non-breaking option, I think so.
I was thinking closer integration with https://github.com/hexorx/countries would provide options for greater flexibility with the generated control. I.E. My use case is for phone number country code selection, so including the international prefix in the display value would be beneficial to my users. May be to tangential for this project, but just an idea.

[stefanpenner]

@auzroz integrating with the countries gem may be good idea, typically I try to restrict the number of dependencies, but in this case I believe it is a clear win.

[stefanpenner]

fixed by: 4948b6e

I am still interested in integrating with the countries gem, if someone has some time a PR would be welcomed.

[auzroz]

Completed a basic integration (COUNTRIES list is generated by the countries gem). Pull Request - #33