Comments (12)
Hey Sebastian!
The project is released under an MIT license (I should update the readme to reflect this). If you're interested in porting it over to using the latest jQuery and jQuery UI that would be really great. I'd love to accept a pull request with those changes in there :)
Please feel free to use it commercially.
Cheers,
Addy
from coverflow.
In case they're helpful here are some commits on other forks that you may be interested in also pulling in:
- Fixes to the "flow": toAtulArora@b098f33
- Click to flip, better support for mousewheel: https://github.com/code4ghana/jqueryui-coverflow-ii/commits/master/
from coverflow.
\o/
That's great news ;) I'll take a look at the commits you provided.
I'd love to accept a pull request with those changes in there :)
Will do my very best ;)
Thank you very much again!
Sebastian
from coverflow.
Hey Addy,
just wanted to let you know I already refactored it a lot (tbh: i began to play with that code before I asked about the license ;) ).
If you are curious I already pushed it towards my fork. I'll reinclude IE support asap - but I'm not sure if sylvester dependency is really needed.
Nice to have features I plan to add:
grunt build system
qunit tests
better reflection support (-moz-element)
best regards
Sebastian
from coverflow.
That's awesome! I'll take a look at your fork right away. The IE support added back in would be great. To be honest. Sylvester was included there to support all of the necessary transforms needed to get IE rendering looking 100% like it was in modern browsers, but its possible if we're just targeting say, IE8+ that may not be needed.
The grunt build system would be awesome and if you need any help with it, do let me know. Would love to see the better reflection support :)
from coverflow.
Just a heads up that earlier when I cloned your fork and switched to the 1.9 branch there were some issues with jQuery/jQuery UI paths not being resolved. Not sure if this was just me but thought I'd point it out :)
from coverflow.
I rechecked towards my local repo, seems to be submodule related.
Run git pull origin master && git submodule update --init
and "all" problems should be gone (besides the big todos left ;) ).
I'll continue on Tuesday/Wednesday (and maybe provide a better readme ;) )
from coverflow.
@basti1253 That solved it!. Nice work :) I'll check out your progress on Tuesday. I probably should update the README in this repo anyway to reflect some more info about the project.
from coverflow.
Thanks ;) I already reincluded IE support into the plugin and dropped sylvester/transformie.
There's still a minor positioning issue - both with the old and the refactored plugin. You can see that when opening tests/visual.html (or tests/visualOld.html for version 2.2 ) in any modern browser. The animation doesn't really center the active element - an infinitive scroll would not be possible (I'm already digging into that).
If you want I'll keep you updated ;)
from coverflow.
Hey Addy,
I fixed the positioning bug (I missed the float:left attribute on images in your original example :( ) and added a few more bindings into the plugin:
mobile swipe support
keyboard navigation with tab
mousewheel support
I already added grunt - thatfore I moved the jquery-ui submodule to libs/. You'll need to run git submodule sync
- if that's not working I'd recommend to check out the repo again (fixing that by hand may last longer).
best regards
Sebastian
from coverflow.
@basti1253 Great work on fixing the positioning bug and addition bindings! It's also welcome to see the grunt setup is now in place.
With respect to the mobile swipe support, I assume this just relates to the swipe events and you aren't targeting mobile support with the coverlow component too? :) Just for interest: I initially looked into this for the project but found that there were much more performant pure CSS3-only implementations that worked better on mobile devices.
Do you need assistance with cross-browser testing?
Aside: Reading through your readme I'm assuming (correct me if I'm wrong) that you'd like to become the recommended fork for the project. If I've mistaken this, please feel free to let me know. I don't mind at all accepting the updates you're making as a pull request (although, I'll probably pull them in for the lazy anyway and recommend viewing your fork for all future updates if you do plan on becoming an active fork).
My blog posts on the original coverflow project still get a few questions/feature requests sent through every week and I don't at all mind linking people to an issue tracker where they'll be able to get help. There definitely is enough work there for a full-time OSS project, but again, knowing your intentions would be awesome for planning. Do you plan on actively maintain your fork for another year or so?.
Either way, I'm really glad to see someone working on updating the project and appreciate the work you're doing :)
from coverflow.
With respect to the mobile swipe support, I assume this just relates to the swipe events and you aren't targeting mobile support with the coverlow component too? :)
Currently I'm not sure about full mobile support. At the moment I'd like to keep the javascript animation and maybe improve mobile support in a later version.
@ README:
it's really a lousy draft - nothing more. To be honest I didn't think about maintaining the "recommended" fork and moving project home over to my github account. Besides that a helping hand on the README would be fantastic - as I'm not a native speaker this just can get improved.
The main motivation was to play around with that code, understand it, improve my animation skills, getting familiar with grunt and other stuff. Usually I do paid, closed source coding - this time I just wanted to give something back and share it with others (that sounds so off-repeated..).
I'd appreciate it very much if you'd accept a pull request when the code is good enough and ready. I'd leave the project home where it is (your repository), as it's your baby - but that's totally up to you.
Do you plan on actively maintain your fork for another year or so?
I'd have to maintain the code anyways as I plan to use it on a bigger page I'm regularly working on ;) Having public feedback/others testing the code would be a great plus.
Do you need assistance with cross-browser testing?
Not at the moment ;) I'll test it on iOS and IE < 8 next week. Currently I test on IE 8 and IE9, Firefox, Chrome/ium and android browsers.
Either way, I'm really glad to see someone working on updating the project and appreciate the work you're doing :)
You embarass me ;)
from coverflow.
Related Issues (20)
- Scrollbar and image alt ? HOT 2
- publish bower dependency
- #feature: Integration with knockout HOT 1
- Lack of documentation
- Newest Code is broken HOT 3
- IE9 Alignment issue HOT 2
- Blank page ?
- Cannot move to next coverflow item on jquery click event HOT 4
- Delete images HOT 1
- How can I add mousewheel throttle/debounce? HOT 7
- requiring dependancies HOT 1
- Getting started Instructions HOT 2
- Image sizes can cause it to break HOT 1
- AJAX Reload HOT 2
- Don't have any options for looping
- How to change the left of element whose class name is coverflow ? HOT 1
- adding active event causes last embedded video to be hidden HOT 1
- adding more gap/space to side of .ui-state-active HOT 5
- Add example on how to implement swipe support with coverflowjs HOT 1
- cocos2djs able can use? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from coverflow.