Comments (1)
I think any I/O should stay out of such a library. In general, this is probably true of any library :-)
Also, limiting yourself to a file path in the current bundle seems... a bit limiting. For paths out of the bundle, then another method is needed.
And then, one of the main idea of ASCIImage was for me to have the image strings right there with the code instead of having to chase down a file in the resources.
Finally, I am always wary of multiplying the convenience methods that only save a couple of lines of code and that can lead to API confusion and multiplication. I realize you only propose one here, but I guess I am worried about the slippery slope. I am already not so happy about having 2 separate methods when actually the 'simple' one can be expressed very simply with the block method. The 'simple' method is only there because that was initially the only method I had.
In conclusion, I'll close the issue, sorry!
To end on a positive note, however, I'd be happy to allow input to be a string instead of an array, using (id) as the type so both can work. It's very easy to handle both by checking the class and split a string into multiple lines as part of preprocessing.
from asciimage.
Related Issues (11)
- Create pixel-aligned Bezier curves for ellipses as well
- Expose the parsing code
- Animate between images HOT 1
- Implementation-independent context/path metadata? HOT 29
- ASCIIImage as Xcode plugin, with Monodraw HOT 6
- Should have Cocoapods integration HOT 2
- Should move base functionality to a category of NS/UIBezierPath HOT 5
- Have way to specifying subpaths HOT 6
- Support for Apple Watch
- Bug: rendering of single pixels on iOS HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from asciimage.