Giter Site home page Giter Site logo

Comments (7)

craffel avatar craffel commented on August 18, 2024

@douglaseck if this is solved in be70895 can you close? Thanks.

from pretty-midi.

douglaseck avatar douglaseck commented on August 18, 2024

I tried by doing this:
git commit --amend -m "Add a comparator for sorting a track that handles
all event types. Fixes #61"
git pull
git push origin master

So I think that put "Fixes 61" in the commit message.

Git is becoming less magical as I use it, but the less magical it becomes,
the more I'm somewhat annoyed by it. I'm sure I'll learn. There's got to be
a good reason it took over the world. There's got to be a reason you can't
just close an open issue by clicking "Close" somewhere on the issue . ..

On Tue, May 10, 2016 at 2:16 PM, Colin Raffel [email protected]
wrote:

@douglaseck https://github.com/douglaseck if this is solved in be70895
be70895
can you close? Thanks.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#61 (comment)

from pretty-midi.

craffel avatar craffel commented on August 18, 2024

So, that would work on your own fork; you can only push commits to your fork of pretty-midi, not my fork. There is indeed a "close" button, it's next to the "comment" button on the issues page:
#61
You are getting me curious as to how they do things internally at Google...

from pretty-midi.

douglaseck avatar douglaseck commented on August 18, 2024

But I think that close button only shows up for the owner of the issue. See
attached screenshot of what I see.

On Tue, May 10, 2016 at 3:59 PM, Colin Raffel [email protected]
wrote:

So, that would work on your own fork; you can only push commits to your
fork of pretty-midi, not my fork. There is indeed a "close" button, it's
next to the "comment" button on the issues page:
#61 #61
You are getting me curious as to how they do things internally at Google...


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#61 (comment)

from pretty-midi.

craffel avatar craffel commented on August 18, 2024

Oops, sorry, I had thought you had opened this issue (you just reported it). I'll close it!

from pretty-midi.

douglaseck avatar douglaseck commented on August 18, 2024

So git/github is not all that crazy after all :-)

On Tue, May 10, 2016 at 5:04 PM, Colin Raffel [email protected]
wrote:

Oops, sorry, I had thought you had opened this issue (you just reported
it). I'll close it!


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#61 (comment)

from pretty-midi.

craffel avatar craffel commented on August 18, 2024

Haha, yeah, just me...

from pretty-midi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.