Comments (7)
@douglaseck if this is solved in be70895 can you close? Thanks.
from pretty-midi.
I tried by doing this:
git commit --amend -m "Add a comparator for sorting a track that handles
all event types. Fixes #61"
git pull
git push origin master
So I think that put "Fixes 61" in the commit message.
Git is becoming less magical as I use it, but the less magical it becomes,
the more I'm somewhat annoyed by it. I'm sure I'll learn. There's got to be
a good reason it took over the world. There's got to be a reason you can't
just close an open issue by clicking "Close" somewhere on the issue . ..
On Tue, May 10, 2016 at 2:16 PM, Colin Raffel [email protected]
wrote:
@douglaseck https://github.com/douglaseck if this is solved in be70895
be70895
can you close? Thanks.—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#61 (comment)
from pretty-midi.
So, that would work on your own fork; you can only push commits to your fork of pretty-midi
, not my fork. There is indeed a "close" button, it's next to the "comment" button on the issues page:
#61
You are getting me curious as to how they do things internally at Google...
from pretty-midi.
But I think that close button only shows up for the owner of the issue. See
attached screenshot of what I see.
On Tue, May 10, 2016 at 3:59 PM, Colin Raffel [email protected]
wrote:
So, that would work on your own fork; you can only push commits to your
fork of pretty-midi, not my fork. There is indeed a "close" button, it's
next to the "comment" button on the issues page:
#61 #61
You are getting me curious as to how they do things internally at Google...—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#61 (comment)
from pretty-midi.
Oops, sorry, I had thought you had opened this issue (you just reported it). I'll close it!
from pretty-midi.
So git/github is not all that crazy after all :-)
On Tue, May 10, 2016 at 5:04 PM, Colin Raffel [email protected]
wrote:
Oops, sorry, I had thought you had opened this issue (you just reported
it). I'll close it!—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#61 (comment)
from pretty-midi.
Haha, yeah, just me...
from pretty-midi.
Related Issues (20)
- Wrong tempo HOT 1
- get piano roll with the right sampling rate HOT 10
- Create python wheels for package
- Trim Silence HOT 3
- Is there any way to split a MIDI files into smaller segements based on time in secods/ milliseconds? HOT 1
- _load_metadata does not load lyrics correctly HOT 5
- Numpy type error for int loading midi HOT 3
- Bump version + new pip package HOT 3
- "program_change" event on any channel only effects the current track HOT 5
- Type Mismatch in Calling `fluidsynth.py` HOT 2
- Multitude of set_tempo messages after PrettyMIDI.adjust_times HOT 1
- PrettyMIDI.write error in align_midi.py (ValueError: attribute must be in range 0..16777215) HOT 4
- ValueError when trying to read certain .mid files HOT 1
- Pitch-bend range HOT 5
- Note starting point can be greater than its ending point HOT 1
- complete note conversion feature HOT 1
- fluidsynth: error: Unknown integer parameter 'synth.sample-rate' HOT 5
- Docs apperance HOT 3
- get_piano_roll sustains some notes too long HOT 3
- Midi Markers HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pretty-midi.