Giter Site home page Giter Site logo

Comments (9)

crazko avatar crazko commented on June 1, 2024

Thanks for the report. Could you please help me with the reproduction of this issue? The tiddler title should be present even when you scroll down, but it may be missing in following cases:

  • tiddler is in edit mode
  • you scroll horizontally to quickly so the animation "does not have a time to react"

Could those be causing the issue you have? Or can you describe some steps to reproduce?

from krystal.

arunnbabu81 avatar arunnbabu81 commented on June 1, 2024
  1. I just opened 5 to 6 tiddlers at the same time
  2. Scrolled vertically to the bottom of the tiddler with contents extending more than the vertical length of the screen(not in edit mode).
  3. Scroll horizontally.
  4. Now the title of the tiddler mentioned inn step 2 is either cut off or not displayed (depending on the vertical length of contents in that tiddler)

from krystal.

arunnbabu81 avatar arunnbabu81 commented on June 1, 2024

"When multiple tiddlers are opened, stacking of tiddlers on the left side doesn't reveal the tiddlers title unlike on the right side"
I am seeing this only when I open TW in safari .......its working nicely in tiddlydesktop, chrome/edge browsers and even in tiddloid android app and I love the way Krystal behaves in android tablet. Its very user friendly.

Few points which I noted which can even improve Krystal are:

  1. Providing a keyboard shortcut for going into and coming out of the maximised state of a tiddler
  2. Suppose a tiiddler is open in its maximised state and i clicked on a link within that tiddler, the linked tiddler won't be seen unless i come out of the maximised state. Can there a option to open those linked tiddlers without coming out of the maximised state - either by opening them in a pop up or as a spilt window. By split window I mean that the already opened tiddler which was in the maximised state should move to the left half of the screen and the linked tiddler which I clicked should open in the right half of the screen if I click on the link using 'shift+click'. If I open anymore linked tiddlers, they should replace the tiddler occupying the right of the screen.

from krystal.

crazko avatar crazko commented on June 1, 2024

I am seeing this only when I open TW in safari

Unfortunately, I can't test it in Safari.

  1. Providing a keyboard shortcut for going into and coming out of the maximised state of a tiddler

That's a good idea.

  1. Suppose a tiiddler is open in its maximised state and i clicked on a link within that tiddler, the linked tiddler won't be seen unless i come out of the maximised state. Can there a option to open those linked tiddlers without coming out of the maximised state - either by opening them in a pop up or as a spilt window. By split window I mean that the already opened tiddler which
    was in the maximised state should move to the left half of the screen and the linked tiddler which I clicked should open in the right half of the screen if I click on the link using 'shift+click'. If I open anymore linked tiddlers, they should replace the tiddler
    occupying the right of the screen.

I'm afraid by implementing this it'll start to be a bit over-complicated. If anything, by clicking on the link in the maximised state it returns back to the default state is something I can imagine.

from krystal.

arunnbabu81 avatar arunnbabu81 commented on June 1, 2024

Keyboard shortcut for going into and coming out of the maximised state of a tiddler will be very handy.

"Clicking on the link in a tiddler in the maximised state returns back to the default state" - Providing this option also will definitely enhance the workflow.

I also I want a keyboard shortcut to not close tiddlers to the right. Currently if we open multiple tiddler from recents or if we open multiple links from a single tiddler, the second opened tiddler will replace the first opened tiddler and so on. But if you can configure it like this it will be better - just 'clicking' on the links will behave normally, but if we 'shift-click' on the link, the tiddlers to the right should not close. I know that there is an option to configure it in the settings. But it affects the workflow if we have to go to settings every time to change it.

Only problem now remaining will be when 4 or more tiddlers are open simultaneously, it will be difficult to see and compare two non-adjacent tiddlers. For example, if I want to see 2nd and 5th tiddler simultaneously, its not possible in the current set up. But this is not a big problem. I have encountered such situation once in a while only. Can you think of any workaround for this?

Also, do you find dropdown option for the contents in the the topbar useful? I have found such a setup in mentat story river (https://thesherwood.github.io/Mentat/) and at http://tongerner.tiddlyspot.com.

I am very happy using Krystal and I have built my personal tiddlywiki based on Krystal.
The plug ins which I use most commonly are flibbles/relink, snowgoon88/edit-comptext, linonetwo/copy-on-select, souk21/command palette, sq/editor-autolist. I also found these plug ins very useful - wikilabs/multicol-dropdown and edit-tabs, kookma/utility, tobibeer/preview, danielo515/ContextPlugin, TWaddle /richlinks, jd/fullscreen-editor, kebi/tiddlyresearch-references and twitter plug in.

from krystal.

crazko avatar crazko commented on June 1, 2024

Let's discuss all the other things in a separate issues.

from krystal.

crazko avatar crazko commented on June 1, 2024

If someone is able to investigate this issue (stacking in the left side) in Safari browser, let me know.

from krystal.

ericworks avatar ericworks commented on June 1, 2024

This issue can be reproduced on Firefox 84. I did not test it with Safari, but I believe the behaviour on Firefox is similar with Safari --- The stacked tiddlers' title are not shown (blank).

I investigate the class name and find out that the class name krystal-tiddler__frame--overlay and krystal-tiddler__frame--hide are not added to the stacked tiddlers' title DIV. This may imply that the condition check for stacking tiddlers is not met due to some reasons.

I debug the code in plugin.js, and notice the tiddlerPadding has different value on Chromium and Firefox --- correct value on Chromium and 0 on Firefox. With further investigation on the window.getComputedStyle(tiddlers[0]) function, I finally figure out that this is the issue root. Below are the returned values on Chromium:

...,
padding: "31px"
paddingBlock: "31px"
paddingBlockEnd: "31px"
paddingBlockStart: "31px"
paddingBottom: "31px"
paddingInline: "31px"
paddingInlineEnd: "31px"
paddingInlineStart: "31px"
paddingLeft: "31px"
paddingRight: "31px"
paddingTop: "31px"
...

And below are the returned values on Firefox:

...,
padding: ""
"padding-block": ""
"padding-block-end": "31px"
"padding-block-start": "31px"
"padding-bottom": "31px"
"padding-inline": ""
"padding-inline-end": "31px"
"padding-inline-start": "31px"
"padding-left": "31px"
"padding-right": "31px"
"padding-top": "31px"
paddingBlock: ""
paddingBlockEnd: "31px"
paddingBlockStart: "31px"
paddingBottom: "31px"
paddingInline: ""
paddingInlineEnd: "31px"
paddingInlineStart: "31px"
paddingLeft: "31px"
paddingRight: "31px"
paddingTop: "31px"
...

There is a similar issue here, stating that the padding property only works for Chromium based browser. The problem seems that Firefox treat height, width, padding differently.

I attempt to modify the code in plugin.js and change it into window.getComputedStyle(tiddlers[0]).paddingRight.slice(0, -2) in order to verify the assumption. It turns out that after changing the paddingRight, the stacking title shows as expected on Firefox (Chromium too).

This is quite an ad-hoc solution (I guess). Not sure if any better solution to get the padding values from the plugin settings directly.

from krystal.

crazko avatar crazko commented on June 1, 2024

This is quite an ad-hoc solution (I guess). Not sure if any better solution to get the padding values from the plugin settings directly.

It'd be possible to get it from the settings, you are right. Another way would be to get custom CSS property directly (I just learned it's also possible):

window.getComputedStyle(tiddlers[0]).getPropertyValue('--tiddler-padding')

Your solution works, so let's stick with that :) thanks

from krystal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.