How to support slice of struct?

[ludanfeng]

How to support slice of struct?

[creasty]

Could you try this?

type confStruct struct {
	ID     string       `yaml:"id"`
	Modules []confModule `yaml:"modules" default:"[]"`
}

[ludanfeng]

Could you try this?

type confStruct struct {
	ID     string       `yaml:"id"`
	Modules []confModule `yaml:"modules" default:"[]"`
}

Does not work. The following is the test result and case:
Diff:
--- Expected
+++ Actual
@@ -5,6 +5,3 @@
Name: (string) (len=2) "m1",
- Params: ([]string) (len=2) {
- (string) (len=2) "-c",
- (string) (len=8) "conf.yml"
- }
+ Params: ([]string)
},

package utils

import (
	"testing"

	"github.com/creasty/defaults"

	"github.com/stretchr/testify/assert"
)

type confModule struct {
	Name   string   `yaml:"name"`
	Params []string `yaml:"params" default:"[\"-c\", \"conf.yml\"]"`
}

type confStruct struct {
	Others  string       `yaml:"others"`
	Modules []confModule `yaml:"modules" default:"[]"`
}

func TestSetDefaults(t *testing.T) {
	tests := []struct {
		name    string
		args    *confStruct
		want    *confStruct
		wantErr bool
	}{
		{
			name: "defaults-struct-slice",
			args: &confStruct{
				Others: "others",
				Modules: []confModule{
					confModule{
						Name: "m1",
					},
					confModule{
						Name:   "m2",
						Params: []string{"arg1", "arg2"},
					},
				},
			},
			want: &confStruct{
				Others: "others",
				Modules: []confModule{
					confModule{
						Name:   "m1",
						Params: []string{"-c", "conf.yml"},
					},
					confModule{
						Name:   "m2",
						Params: []string{"arg1", "arg2"},
					},
				},
			},
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			if err := defaults.Set(tt.args); (err != nil) != tt.wantErr {
				t.Errorf("SetDefaults() error = %v, wantErr %v", err, tt.wantErr)
			}
			assert.Equal(t, tt.want, tt.args)
		})
	}
}

[ludanfeng]

And my current workaround is：

package utils

import (
	"reflect"

	"github.com/creasty/defaults"
	"github.com/juju/errors"
)

// SetDefaults set default values
func SetDefaults(ptr interface{}) error {
	err := defaults.Set(ptr)
	if err != nil {
		return errors.Errorf("%v %s", ptr, err.Error())
	}

	v := reflect.ValueOf(ptr).Elem()
	t := v.Type()

	for i := 0; i < t.NumField(); i++ {
		if f := t.Field(i); f.Type.Kind() == reflect.Slice {
			slice := v.Field(i)
			for j := 0; j < slice.Len(); j++ {
				sliceItem := slice.Index(j)
				if sliceItem.Kind() != reflect.Struct {
					continue
				}
				sliceItemTemp := reflect.New(sliceItem.Type())
				sliceItemTemp.Elem().Set(sliceItem)
				err = SetDefaults(sliceItemTemp.Interface())
				if err != nil {
					return errors.Trace(err)
				}
				sliceItem.Set(sliceItemTemp.Elem())
			}
		}
	}
	return nil
}

[creasty]

Fixed in https://github.com/creasty/defaults/releases/tag/v1.3.0