Comments (17)
Okay @akmadian I understand how it works now, thanks.
from chooser.
Hi @akmadian, I'm an Outreachy applicant. I will try to work on this. Thank you!
from chooser.
I’m happy to help anywhere Vocabulary usage is involved!
from chooser.
Go ahead! @deboragaleano
from chooser.
Hi @akmadian can I work on this too?
from chooser.
Sorry, @onyijne, this issue is already being worked on by someone else. Keep checking back on the repository cause I'll be adding more issues soonish. Any issue with the in progress
tag is already being worked on by someone else.
from chooser.
So sorry but I won't be able to work on this issue in the end. I believe @onyijne can take it now :) Thank you!
from chooser.
It's okay @deboragaleano, @akmadian can I go ahead?
from chooser.
Yep, go ahead @onyijne :)
from chooser.
@dhruvkb please how can I access the @creativecommons/vocabulary dir. can't seem to locate it.
This is what I have now, can't find the Footer component to enable me edit the first two parts.
from chooser.
Okay my IDE kinda hid the dir, but how do I push changes I'll make in the vocabulary package since it's in node_modules dir?
from chooser.
Either make a pull request to the cc-vocabulary repo with your changes (make sure they don't break anything else in vocabulary), or make changes to the CSS in components that need attention in the cc-chooser source (this option is far better in my opinion). For the footer, your CSS mods should be in the App.vue parent component.
from chooser.
@akmadian I might have to make a pull request to the cc-vocabulary repo as the footer requires more than CSS, the wording and logo needs modification. However, if you do not recommend making a pull request to cc-vocabulary repo, and would permit me to I can use DOM manipulation to effect the changes.
from chooser.
I was saying that (maybe I could have been more clear), chances are that there's some CSS within the chooser that's causing issues with vocab components, and that it's better to find the problematic CSS and fix it instead of modifying vocabulary in node_modules.
Although, it sounds like you may have found a deeper issue with vocabulary. So, if you've got a fix for that issue, and it happens to also fix this one, then that sounds better to me. If you did find a deeper issue, I would definitely submit a PR to vocab, then do what's needed to fix the issue in the chooser if it still needs some work.
from chooser.
I
Due to issues with specificity, styling provided by CC Vocabulary is being overriden by styling from other third-party libraries and custom written CSS, leading to a different UI than what is expected. This is causing components to look broken or erratically styled.
To Reproduce
Steps to reproduce the behavior:
- Check out the branch from PR #30
- Run the development server
Expected behavior
The components should render like the examples in the Vocabulary styleguide.Screenshots
^ BrokenFooter
andLocale
^ ExpectedFooter
andLocale
Desktop (please complete the following information):
- OS: Linux (Fedora 30)
- Browser: Firefox
- Version: 68
Looking at the contents on the images for broken and that of expected, they are different. This is what I was actually referring to, and intended to harmonize.
This is what I have done so far
from chooser.
Ah, I see where the confusion is. The content of the footer is not supposed to exactly match the expected footer. The links above the locale selector are meant to be customizable, along with other parts of the footer component. The only real CSS bug I saw in the footer was the weird padding/ alignment of elements in the local selector.
I’ll give some feedback on content in the PR thread.
Sent with GitHawk
from chooser.
from chooser.
Related Issues (20)
- [Bug] No Windows equivalent command for `build-component` in package.json HOT 3
- [Bug] Missing hyperlink in Help Modal HOT 4
- [Feature] The Growing Common Sections looks so messed up HOT 4
- [Bug] full license name should include "Creative Commons" HOT 7
- [Bug] Request to Update Twitter Icon to X HOT 5
- Invalid host header error in Gitpod HOT 2
- [Bug] Creative Commons Icons are missing in Copy Area HOT 7
- [Bug] After finishing the form, clicking "Done" doesn't do anything HOT 1
- [Feature] Offer simple, comprehensive "download license statement" link for all formats HOT 1
- cc-license is not working
- [Bug] Generated HTML img elements have no "alt" attribute for accessibility HOT 8
- Utilize organization default community health files
- [Feature] Dockerization of Creative Commons Chooser Repository HOT 2
- [Bug] Alignment issues in mobile and tablet modes HOT 1
- [Bug] Lack of Clear Menu Icon in Mobile View HOT 2
- [BUG] README file the links are directly displayed as URLs
- [Feature] enable Prettier to run automatically
- [Feature] Vue 2: migrate Vue CLI from v4 to v5
- [Bug] PDM support missing HOT 2
- [Feature] Error pages are not styled/themed HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chooser.