Giter Site home page Giter Site logo

Comments (7)

crflynn avatar crflynn commented on August 21, 2024

I saw your PR for this process but I think it might be simpler to just subclass PoissonProcess and make use of the already existing code. Additionally, you would need to

  • provide init args consisting of an rate_func, as well as rate_args, and rate_kwargs for that function to ensure it is generalized enough for any rng package (random, numpy, scipy, etc.).
  • override the rate attribute to call rate_func(*rate_args, **rate_kwargs)

from stochastic.

Gabinou avatar Gabinou commented on August 21, 2024

Following your comments and suggestions, I have implemented changes:

  • MixedPoissonProcess now inherits from Poisson process. I have eliminated some amount of code repetition.
  • Eliminated some other repetitions by way of the gen_rate() method.
  • *rate_args and **rate_kwargs are implemented.
  • New test fixtures for rate_kwargs. The tests seem to be in working order.
  • Modified the continuous.rst to include the MixedPoissonProcess class.

Still to be implemented is:

  • Making sure the code fits style standards. I will work on that for the implementation of the appropriate features, mostly.

Is the pull request in a more acceptable state?
And thank you for your comments and help.

from stochastic.

crflynn avatar crflynn commented on August 21, 2024

This is ok but there are still a lot of issues that need to be addressed.

I think I might merge this into a separate dev branch and clean it up if you don't mind. I'm hoping that maybe you'll track the changes closely and if needed I can explain the reasoning for them. Is that ok?

from stochastic.

Gabinou avatar Gabinou commented on August 21, 2024

This sounds marvelous. When it is up to scratch, I will use it as a template for my future pull requests.

Thank you very much!

from stochastic.

crflynn avatar crflynn commented on August 21, 2024

I requested some changes in the PR. Please address them. Thanks.

from stochastic.

Gabinou avatar Gabinou commented on August 21, 2024

All changes were addressed. If this makes this feature acceptable, I will get to upgrading other features also.

from stochastic.

crflynn avatar crflynn commented on August 21, 2024

@Gabinou I have merged your PR #8 and made several changes that I think make the implementation a bit cleaner. You may refer to the commits in the mixed branch for the changes. Thanks for contributing.

from stochastic.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.