After update to latest rakudo, cookiejar tests fail...

[croservices]

After update to latest rakudo, cookiejar tests fail...

[Xliff]

All tests pass, here. This issue can be closed.

[Altai-man]

Hmm, unfortunately, I am having an issue with reproducing it.

Wed Nov  7 04:05:07 +10 2018
➜  cro-http git:(master) /home/koto/.rakudobrew/moar-master/install/bin/perl6 --version
This is Rakudo version 2018.10-78-g8b93ec9f5 built on MoarVM version 2018.10-72-g4fbaeee5f
implementing Perl 6.d.
➜  cro-http git:(master) /home/koto/.rakudobrew/moar-master/install/bin/perl6 -Ilib t/http-cookiejar.t 
ok 1 - Empty cookie jar contents returns empty list
ok 2 - Empty cookie jar contents with uri returns empty list
ok 3 - Two cookies were added
ok 4 - Cookie addition is neutral
ok 5 - Cookie with bad domain was not added
ok 6 - Uri-based check
ok 7 - Good cookies are here
ok 8 - Clear for absent url leaves jar untouched
ok 9 - Clear for absent url with existing cookie name leaves jar untouched
ok 10 - One cookie was removed
ok 11 - All cookies from correct domain were removed
ok 12 - Call to clear clears cookie jar
ok 13 - Cookie with duration was added successfully
ok 14 - Creation time is preserved during cookie update
ok 15 - Cookie was deleted on negative-time cookie addition
ok 16 - Cookies are added for sub-domains
ok 17 - Rejected for incorrect sub-domain
ok 18 - Header was added
ok 19 - Setted string is correct
1..19
➜  cro-http git:(master) 

I also changed timezone as jnthn suggested, so

➜  cro-http git:(master) date
Wed Nov  7 04:04:50 +10 2018

^ no luck with that.

I've built the same rakudo version. I am on a linux setup. Do you have any clues what might be important here?

[japhb]

What timezone did you change it to? I got the same failure as Xliff did from Pacific Time (UTC-8), and I think it's dependent on being >5 hours west of UTC, so that (((now in local time) + 5 hours) reinterpreted as UTC) appears to be in the past.

[Altai-man]

Reproduced that, fixing.

[Altai-man]

db1a67c
Timezones are tricky, so a review will be welcome, but as a general thing:
1)RFC requires time be passed in GMT, so we do that.
2)Set local expiry time.

This makes tests pass, though I am not really sure how it should behave.

[Altai-man]

ping @Xliff
Can this issue be closed now?

[Xliff]

Ack! Let me check on my end! :)