Giter Site home page Giter Site logo

Comments (11)

tanasebutcaru avatar tanasebutcaru commented on May 27, 2024

Changing 11+ with 12+ in this file libs/xwalk_core_library/xwalk.gradle should do the trick. (didn't tried it)
Also you can check the repo here https://download.01.org/crosswalk/releases/crosswalk/android/maven2/org/xwalk/ ...from what I can see/understand from the repo & xwalk.gradle file, the cordova-plugin-crosswalk-webview installs a beta version of the library, why?

Edit: Tested & working! :)
Just download the 1.0.0 release, unzip and edit the xwalk.gradle file and add the plugin via cordova plugin add <path-to-crosswalk-dir> and that's all.
-- or --
Install the plugin normally and navigate to /platforms/android/cordova-plugin-crosswalk-webview/, open projectName-xwalk.gradle file and change the version and on cordova build/run/emulate the desired version will be used.

Still, question for devs: why do we use the beta library? I thought that it's only for -dev, but after downloading 1.0.0 release I saw that is the same.

from cordova-plugin-crosswalk-webview.

svox1 avatar svox1 commented on May 27, 2024

Thanks for the hint!

from cordova-plugin-crosswalk-webview.

agrieve avatar agrieve commented on May 27, 2024

FYI - just published a new version (v1.1.0) that sets the default version to crosswalk 13, and that makes the crosswalk version configurable via a <preference> (refer to README.md)

from cordova-plugin-crosswalk-webview.

Bnaya avatar Bnaya commented on May 27, 2024

I've opened a feature request to crosswalk to made also canary version available
https://crosswalk-project.org/jira/browse/XWALK-3986
Vote it up please :)

I made that comment on the wrong issue, that should be #24

from cordova-plugin-crosswalk-webview.

svox1 avatar svox1 commented on May 27, 2024

@agrieve
Thats great! Thx!

from cordova-plugin-crosswalk-webview.

hirbod avatar hirbod commented on May 27, 2024

Seems like we had the same idea. See #24 and https://crosswalk-project.org/jira/browse/XWALK-3987

from cordova-plugin-crosswalk-webview.

tanasebutcaru avatar tanasebutcaru commented on May 27, 2024

My question about xwalk library version is still up!
To make it clear: the production ready version is the stable one that can be found here (11.x), right?
So, if someone installs this plugin and immediately runs cordova build android, then the app will use the latest beta version of the crosswalk webview (which is 13 in 1.1.0).

I think that the plugin releases should use only the latest stable version of crosswalk which is listed here.

The current setup may confuse some users that don't pay attention to other details when they build their apps.

Instead of doing this:

<!-- These are all equivalent -->
<preference name="xwalkVersion" value="org.xwalk:xwalk_core_library_beta:13+" />
<preference name="xwalkVersion" value="xwalk_core_library_beta:13+" />
<preference name="xwalkVersion" value="13+" />
<preference name="xwalkVersion" value="13" />

... I propose something like this:

<preference name="xwalkChannel" value="CHANNEL" />
<preference name="xwalkVersion" value="VERSION" />

... where channel possible values are: stable, beta, canary and version - the version number.
Default values: channel - stable & version - latest stable version (11 for now).

from cordova-plugin-crosswalk-webview.

hirbod avatar hirbod commented on May 27, 2024

@tanasebutcaru - best answer and best "way to go" 👍

from cordova-plugin-crosswalk-webview.

tanasebutcaru avatar tanasebutcaru commented on May 27, 2024

Also, some little issues:

  1. Right now when running cordova plugin add cordova-plugin-crosswalk-webview I get a "Not found" result.
  2. If the project has more than one platform (ie: android & ios) the plugin is installed for all:
    Uninstalling cordova-plugin-crosswalk-webview from android Uninstalling cordova-plugin-crosswalk-webview from ios

from cordova-plugin-crosswalk-webview.

hirbod avatar hirbod commented on May 27, 2024

@tanasebutcaru , this should be an own ticket, we should not mix up everything now

from cordova-plugin-crosswalk-webview.

tanasebutcaru avatar tanasebutcaru commented on May 27, 2024

@hirbod you're right. I'll open another issue. :)

from cordova-plugin-crosswalk-webview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.