101 Switching Protocol in json data on the first request

[fliiiix]

101 Switching Protocol in json data on the first request

[gittiver]

I think its the combination of swapping in a thread while also handing it over to the handlers by reference,
but not sure if that is the case.

[gittiver]

maybe an issue with default constructed tread?

https://en.cppreference.com/w/cpp/thread/jthread/swap
std::jthread objects may also be in the state that does not represent any thread (after default construction, move from, detach, or join), and a thread of execution may be not associated with any jthread objects (after detach).

Maybe having a synchronized list or queue for urls and let the player choose from them?
Then play thread could run from the beginning and now swap would be needed?

[fliiiix]

Interesting creating std::jthread current{play_stream, ""}; would also work so maybe calling swap on std::jthread current is undefined behavior?

Although i can not get it to fail on a minimal example without crow.

void play_stream(std::stop_token stoken, std::string stream_url)
{
    std::cout << "mediaplayer: start for " << stream_url << "\n";

    std::promise<void> stop;
    std::stop_callback callBack(stoken, [&stop] {
        std::cout << "mediaplayer: stop\n";
        stop.set_value();
    });

    // wait until cancled
    stop.get_future().wait();
}

int main(int /*ac*/, char** av)
{   
    std::jthread current;
    
    std::jthread play{play_stream, av[0]};
    current.swap(play);
}

And start for 101 Switching Protocol looks like some memory for the request/response in crow.