Fails to compile with gcc 13

[davesteele]

Fails to compile with gcc 13

[davesteele]

I'll give it a try. It will take about a week to get to it.

[smessmer]

Hi @davesteele , I think this was fixed in 3f249ff. Can you check if that works?

[davesteele]

The current releases/0.11, which includes 3f249ff, compiles with gcc-13, but fails (at least) two tests:

[ RUN      ] CryConfigLoaderTest.AsksWhenLoadingNewerFilesystem_AnswerYes
unknown file: Failure
C++ exception with description "stoul" thrown in the test body.
./test/cryfs/impl/config/CryConfigLoaderTest.cpp:316: Failure
Actual function call count doesn't match EXPECT_CALL(*console, askYesNo(HasSubstr("should not be opened with older         versions"), false))...
         Expected: to be called once
           Actual: never called - unsatisfied and active
[  FAILED  ] CryConfigLoaderTest.AsksWhenLoadingNewerFilesystem_AnswerYes (0 ms)
[ RUN      ] CryConfigLoaderTest.AsksWhenLoadingNewerFilesystem_AnswerNo
unknown file: Failure
C++ exception with description "stoul" thrown in the test body.
./test/cryfs/impl/config/CryConfigLoaderTest.cpp:324: Failure
Actual function call count doesn't match EXPECT_CALL(*console, askYesNo(HasSubstr("should not be opened with older     versions"), false))...
         Expected: to be called once
           Actual: never called - unsatisfied and active
[  FAILED  ] CryConfigLoaderTest.AsksWhenLoadingNewerFilesystem_AnswerNo (0 ms)

[smessmer]

I just added a couple of commits to release/0.11 so that its CI runs on more compilers. gcc-13 is one of them. The gcc-13 job does seem to pass all tests. See https://github.com/cryfs/cryfs/actions/runs/5526980172 for a cancelled run that was cancelled after gcc-13 passed or https://github.com/cryfs/cryfs/actions/runs/5534887676 for a full run that (as of the time of this writing) isn't finished yet. Did you use any special build flags that the CI job may not have used?

[smessmer]

ok the full run completed as well now. It passed. Not sure how to reproduce the errors you're seeing. Can you send detailed steps?

[davesteele]

The Build-Depends var in the control file shows the non-core packages that are installed before build/test. The rules file shows the build steps.

[davesteele]

I got my Debian unstable system back online, and the package builds successfully. The failures must have been due to VM issues.

Can you release an 0.11.4 to put this to bed?

[smessmer]

oh great that this is resolved then. I released 0.11.4.