Giter Site home page Giter Site logo

Comments (6)

irenegia avatar irenegia commented on June 15, 2024

when you implement this and close the issue, could you please add a brief description of the design you choose for it?

Thanks!

from retriev.

turinglabsorg avatar turinglabsorg commented on June 15, 2024

we decided to move from ipfs_hash to a more generic deal_uri which can be a single hash, a folder or a string that includes more cids. This will affect the provider-cli package since just before accepting the deal should/must check or retrieve the files someway (this is not a function included in cli at the moment).

from retriev.

0xjona avatar 0xjona commented on June 15, 2024

What about appeals? They refer to one single file of the folder or the whole folder?

from retriev.

turinglabsorg avatar turinglabsorg commented on June 15, 2024

Appeals refers to whole folder, because provider must prove to have all folder, if you have all folder you'll have any single file inside..

If we want to improve granularity we'll need to add a level of complexity, maybe using merkle proofs, but it will complex the contract even more, let's discuss about that.

from retriev.

0xjona avatar 0xjona commented on June 15, 2024

Yes and I actually wanted to ask the same question for when you add a string with multiple CIDs, we apply the same consideration for the folder?
Anyway, we should make explicit what users will be able to do for the ALPHA (it means that this issue is closed, set in #35 and eventually we can open a discussion for future improvement) - do I need to open an issue related to CLI of this?

from retriev.

turinglabsorg avatar turinglabsorg commented on June 15, 2024

Yes open another issue for cli, then we'll decide if add or not several single cids. On the frontend it can be everything packed as folder in any case so we'll never use it. There's enough flexibility to use it as we want.

from retriev.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.