Giter Site home page Giter Site logo

Comments (9)

keplersj avatar keplersj commented on June 19, 2024 1

I'll look into integrating crenv directly

from atom-ide-crystal.

keplersj avatar keplersj commented on June 19, 2024 1

@faustinoaq I like this idea. Let's discuss it in the scry gitter.

from atom-ide-crystal.

keplersj avatar keplersj commented on June 19, 2024

@faustinoaq Thought's on crenv and scry?

from atom-ide-crystal.

faustinoaq avatar faustinoaq commented on June 19, 2024

I used to work with cenv but it uses LLVM 3.5, Would be good a crenv without too old versions of LLVM and crystal.

I mean crenv can install crystal 0.7.0 I think is not too useful in the way this language evolves. Also LLVM 3.5 is generating wrong code see: crystal-lang/crystal#4104

So I provided atom-crystal with /home/username/.crenv/versions/0.19.0/bin for the compiler executable directory.

I think you should use /embedded/bin instead of just /bin

Thought's on crenv and scry?

I think we can let to user specify the path for executable. If executable is in global path, then the extension should detect it and use it by default. By example:

# by default tries to detect if a executable is available.
crystal.compiler = 'crystal'
crystal.server = 'scry'
# If user doesn't have a executable in global path then need to specify path.
# I think this is good because user can specify versions per workspace
crystal.compiler = '/home/username/.crenv/versions/0.19.0/bin'
crystal.server = '/home/main/Projects/scry/scry'

Some of this configuration was an idea by @kofno inside Scry https://github.com/kofno/scry/blob/master/src/scry/protocol/settings.cr#L18
(see command and backend)

from atom-ide-crystal.

faustinoaq avatar faustinoaq commented on June 19, 2024

crenv binaries works as a normal executable, the problem is that CRYSTAL_PATH is empty.

$ ~/.anyenv/envs/crenv/versions/0.18.7/embedded/bin/crystal -v
Crystal 0.18.7 [68783f1] (2016-07-03)
$ ~/.anyenv/envs/crenv/versions/0.18.7/embedded/bin/crystal env
CRYSTAL_CACHE_DIR="/home/main/.cache/crystal"
CRYSTAL_PATH=""
CRYSTAL_VERSION="0.18.7

I think would be easier if user do crenv global <version> instead.

from atom-ide-crystal.

faustinoaq avatar faustinoaq commented on June 19, 2024

from atom-ide-crystal.

keplersj avatar keplersj commented on June 19, 2024

@faustinoaq Where does this fall in relation to scry?

from atom-ide-crystal.

faustinoaq avatar faustinoaq commented on June 19, 2024

I don't think this issue is related to scry, but thanks to it we released Crystal Lang Tools organization 🎉

I think if you want to use a specific crystal version then you should set you desired version as global, I remember crenv has an option for that.

from atom-ide-crystal.

keplersj avatar keplersj commented on June 19, 2024

Closing. Sounds like scry should support this out of the box, and this package is just a wrapper around scry now. Please, reopen if this isn't true.

from atom-ide-crystal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.