Add an External Call Not Tested Vuln

[crytic]

Add an External Call Not Tested Vuln

[offlinemark]

This one is basically "don't use address.send()"

http://solidity.readthedocs.io/en/develop/types.html#members-of-addresses

There are some dangers in using send: The transfer fails if the call stack depth is at 1024 (this can always be forced by the caller) and it also fails if the recipient runs out of gas. So in order to make safe Ether transfers, always check the return value of send, use transfer or even better: use a pattern where the recipient withdraws the money.

address.transfer() seems preferable in nearly all cases, as it automatically does error checking. i suppose the exception would be if you want to do some advanced error handling if a .send fails.

[offlinemark]

also mentioned here: https://github.com/ConsenSys/smart-contract-best-practices#handle-errors-in-external-calls

[offlinemark]

also sorry for changing the name of this issue :( the original was better