Problem parsing supplementary credentials

[csababarta]

Problem parsing supplementary credentials

[csababarta]

Hi PAFsec,

i decided to implement a different solution to your problem. Could you please check if it works?
Let me know if you still have the decoding problem.

Thanks for your bug report.

[PAFsec]

Hello,

I just checked your modifications.
If I only give the --supplcred argument, it looks like it work well.

Although, giving all the needed inputs to retrieve passwords hashes got me the same kind of decoding error than previously mentionned:

  File "dsusers.py", line 486, in <module>
    processUser(user)
  File "dsusers.py", line 181, in processUser
    creds = user.getSupplementalCredentials()
  File "/opt/ntdsxtract/ntds/dsobjects.py", line 255, in getSupplementalCredentials
    return dsSupplCredentials(tmpdec)
  File "/opt/ntdsxtract/ntds/dsobjects.py", line 507, in __init__
    self.ParseUserProperties(text)
  File "/opt/ntdsxtract/ntds/dsobjects.py", line 575, in ParseUserProperties
    offset = self.ParseUserProperty(text, offset)
  File "/opt/ntdsxtract/ntds/dsobjects.py", line 618, in ParseUserProperty
    self.Password = unicode(unhexlify(text[offset:offset+ValueLength]).decode('utf-16')).encode('utf8')
  File "/usr/lib64/python2.7/encodings/utf_16.py", line 16, in decode
    return codecs.utf_16_decode(input, errors, True)
UnicodeDecodeError: 'utf16' codec can't decode bytes in position 100-101: illegal encoding

Thank you for your work.

[csababarta]

Hi PAFsec,

here is another version. Unfortunately as I cannot really reproduce the error, I cannot do real testing. Could you please test this version. In case of any exception it should dump the data in hex which should work fine.