Giter Site home page Giter Site logo

Comments (5)

elnino79 avatar elnino79 commented on July 28, 2024

I found a solution in responsive theme. In fn scrollToElm(), before (line 1442, core.js):

            if (!elm.size()) {
                return;
            }

you have to add:

            if (typeof(elm) === 'string') {
                if (elm.length && elm.charAt(0) !== '.' && elm.charAt(0) !== '#') {
                    elm = '#' + elm;
                }
                elm = $(elm);
            }  

Normally to scrollToElm() is passed jQuery object, but sometime other function just pass class name.

from cscart-boilerplate.

alpharder avatar alpharder commented on July 28, 2024

Thanks for the report.

from cscart-boilerplate.

moondawg69 avatar moondawg69 commented on July 28, 2024

I replaced that code as per the solution by elino79 but then that results in:

'undefined is not an object (evaluating 'elm.offset().top')'

Which then breaks the product filters, you can only filter 'once' and then not again, without refreshing the page.

Kind of a breaking point of the site in general, I would appreciate a fix asap please, CS Cart team.

from cscart-boilerplate.

torunar avatar torunar commented on July 28, 2024

Hello, @elnino79, @moondawg69.
Can you please check if #83 fixes the issue for you?

from cscart-boilerplate.

kugimiya avatar kugimiya commented on July 28, 2024

PR #89 fix this issue.

from cscart-boilerplate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.