[BUG] Figure out a better way to redirect from the question submission page

[ykdojo]

[BUG] Figure out a better way to redirect from the question submission page

[sanyamjain04]

I have solved this issue in one line. Can I create a PR @ykdojo ?

[Olyno]

I looked at the repo, and this one is exactly like the current one. Both repos use an authentication system on the client with local storage, which is a bad practice in my opinion.

Supabase provides many tools to make authentication simple, but you are using localStorage as verification, which is not secure at all.

[ykdojo]

Thank you. I added a comment on #272

[Olyno]

Hi 👋🏻 I could help, can you indicate me where the redirection is?

[ykdojo]

@Olyno thank you. Did you try finding it yourself first?

[Olyno]

Actually, i got a look in the code, and got confused by how Supabase was used. I'm not sure why you're using Supabase on the server side only, while you could use on the client.

I think the way to solve your issue would be to move the auth security on the server side, and remove the session object to use the user object from Supabase directly, using the Supabase auth helper. I can do it for you if that's okay.

[ykdojo]

Actually, i got a look in the code, and got confused by how Supabase was used. I'm not sure why you're using Supabase on the server side only, while you could use on the client.

This repo will hopefully help you understand it better: https://github.com/ykdojo/supabase-nextjs-simple-auth

[Olyno]

This repo will hopefully help you understand it better: ykdojo/supabase-nextjs-simple-auth

I mean, look at the pr i did, this is completely different

[ykdojo]

@Olyno did you look though this repo though?

[ykdojo]

How would you recommend that we implement this then?

[Olyno]

As I said, the best would be to use the tools that Supabase offers, and to make an authentication in SSR if you use a server part. If you use only client, in this case it should be privileged that the client, but it is not your case.

You can see the implementation I recommend in PR #272

[Akshay1018]

defaang_.recently-asked.interview.questions.at.FAANG+.collected.curated.-.Google.Chrome.2022-10-08.00-43-51.mp4

[Akshay1018]

I tried to solve it on my local machine. My approach is to take the session as a prop and while routing the submit question using href, add a ternary check if the session is there then redirect to an add question page otherwise signup page.

[Akshay1018]

Another way to resolve this issue is by adding private routes for the pages where we need the user should be logged in.